fix: Fix race condition with using newer NodePool for hash annotation #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
jonathan-innis
force-pushed
the
fix-hash-race-condition
branch
from
4e6d241
to
603c1fa
Compare
Pull Request Test Coverage Report for Build 10913694297Details
💛 - Coveralls |
rschalo
reviewed
Sep 16, 2024
jonathan-innis
force-pushed
the
fix-hash-race-condition
branch
from
603c1fa
to
604a329
Compare
jonathan-innis
force-pushed
the
fix-hash-race-condition
branch
from
604a329
to
1112aea
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jeevanpuchakay
pushed a commit
to jeevanpuchakay/karpenter
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Fix hash annotation being generated from a newer NodePool than used during scheduling. This new code guarantees that the NodePool that is used during scheduling is what will be used to generate the hash annotation.
This ensures that if the NodePool changes while we are scheduling, we won't use the new configuration to generate the hash, which could lead to use putting a hash on the NodeClaim that doesn't actually represent the configuration that the NodeClaim was generated from.
How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.