Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Additional upstream metrics #1672

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: Additional upstream metrics #1672

merged 1 commit into from
Sep 25, 2024

Conversation

jigisha620
Copy link
Contributor

@jigisha620 jigisha620 commented Sep 17, 2024 •
edited
Loading

Fixes #N/A

Description
Adding new metrics.

  1. karpenter_nodes_drained_total
  2. karpenter_ignored_pod_count
  3. karpenter_pods_current_unbound_duration_seconds
  4. karpenter_pods_bound_duration_seconds
  5. karpenter_pods_unstarted_time_seconds
  6. karpenter_cluster_state_unsynced_time_seconds
  7. karpenter_nodes_eviction_requests_total

How was this change tested?
Added tests and tested on local cluster

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jigisha620. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2024
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11025328571

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 8 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 80.771%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/scheduling/preferences.go 7 86.67%
Totals Coverage Status
Change from base Build 11023950861: 0.04%
Covered Lines: 8443
Relevant Lines: 10453
💛 - Coveralls

@jigisha620 jigisha620 force-pushed the additional-metrics branch 5 times, most recently from 448ac20 to d8bd4a8 Compare September 17, 2024 21:31
@jigisha620 jigisha620 force-pushed the additional-metrics branch 2 times, most recently from 82fd92c to 1dbd11d Compare September 18, 2024 00:40
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@jigisha620 jigisha620 changed the title chore: Additional upstream metrics Part1 chore: Additional upstream metrics Sep 19, 2024
jonathan-innis
jonathan-innis reviewed Sep 20, 2024
View reviewed changes
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/node/termination/terminator/eviction.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/metrics/constants.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
@jigisha620 jigisha620 force-pushed the additional-metrics branch 2 times, most recently from ac04b26 to c437c76 Compare September 20, 2024 20:25
jonathan-innis
jonathan-innis reviewed Sep 23, 2024
View reviewed changes
pkg/metrics/constants.go Outdated Show resolved Hide resolved
pkg/controllers/state/suite_test.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/controllers/state/cluster.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
@jigisha620 jigisha620 force-pushed the additional-metrics branch 3 times, most recently from 2425745 to 58ca682 Compare September 24, 2024 17:15
@jigisha620 jigisha620 force-pushed the additional-metrics branch 2 times, most recently from 107858d to 4e3cd49 Compare September 25, 2024 02:28
jonathan-innis
jonathan-innis approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 769f811 into kubernetes-sigs:main Sep 25, 2024
11 checks passed
jeevanpuchakay pushed a commit to jeevanpuchakay/karpenter that referenced this pull request Oct 6, 2024
@jigisha620 @jeevanpuchakay
chore: Additional upstream metrics (kubernetes-sigs#1672)
63dd570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jigisha620 @k8s-ci-robot @coveralls @jonathan-innis