Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request - label nodes in provider with network name #3836

Closed
TrooperT opened this issue Jan 4, 2025 · 2 comments
Closed

Enhancement Request - label nodes in provider with network name #3836

TrooperT opened this issue Jan 4, 2025 · 2 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@TrooperT
Copy link

TrooperT commented Jan 4, 2025

What would you like to be added:
I would like for it to be considered for the built-in providers (docker, podman, nerdctl) to provision the nodes with an additional label, perhaps in the format io.x-k8s.kind.network=<networkName>

Why is this needed:

Acknowledging that env variable KIND_EXPERIMENTAL_DOCKER_NETWORK is taken into account during cluster creation for setting the provider network each node is connected to, AND that it is an experimental flag at that, adding this label lays the foundation for a further enhancement to cloud-provider-kind allowing the spawned loadbalancer nodes to be properly connected to the same network as the cluster they are serving.

I have a branch ready for PR if things are amenable: TrooperT/kind

@TrooperT TrooperT added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 4, 2025
@BenTheElder
Copy link
Member

Not only do we only officially support one network name, the container labels are not documented because they're an internal mechanism.

You can discover this information from docker inspect

@BenTheElder BenTheElder self-assigned this Jan 6, 2025
@TrooperT
Copy link
Author

TrooperT commented Jan 6, 2025

Darn. Thought I had a good one.

@BenTheElder thank you for the insight and helping me to course correct the project I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants