Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs are obtained after the cluster is up and before the tests run #271

Open
aojea opened this issue Oct 14, 2024 · 2 comments
Open

Logs are obtained after the cluster is up and before the tests run #271

aojea opened this issue Oct 14, 2024 · 2 comments

Comments

@aojea
Copy link
Contributor

aojea commented Oct 14, 2024

As a consequence there is no possibility of debugging test failures, IIRC the logs should be obtained before we are tearing down the cluster, but when this option was added , it got added to the Up() hook https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-gce-conformance-latest-kubetest2/1845682784069226496

fb21a08

It seems the AWS one logs correctly

https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-cloud-provider-aws-e2e-kubetest2/1845768599910748160

@aojea
Copy link
Contributor Author

aojea commented Oct 14, 2024

/cc @BenTheElder @krzyzacy

@aojea
Copy link
Contributor Author

aojea commented Oct 14, 2024

Suggestions from @soltysh seems the best one, moving the dump of the logs to the Down() hook

https://github.com/kubernetes-sigs/kubetest2/blob/master/kubetest2-gce/deployer/down.go#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant