missing --container-runtime-endpoint flag

[elieser1101]

Its not possible at the moment to set the --container-runtime-endpoint and always defaults to unix:///run/containerd/containerd.sock which becomes a problem while trying to test with crio

I found out that the runs of some jobs like pull-kubernetes-node-crio-cgrpv2-imagefs-e2e-kubetest2 are running with this value --container-runtime-endpoint pased multiple times. This is because this is wrapped on test-e2e-node.sh but we still need to pass the CONTAINER_RUNTIME_ENDPOINT for the makefile to actually replace it.

Failure Finished Test Suite on Host n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5. Refer to artifacts directory for ginkgo log for this host.
command [ssh -o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /root/.ssh/google_compute_engine [email protected] -- sudo /bin/bash -c 'cd /tmp/node-e2e-20241123T111515 && set -o pipefail; timeout -k 30s 0.000000s ./ginkgo -timeout=24h -nodes=8  -focus="\[NodeConformance\]|\[NodeFeature:.+\]|\[NodeFeature\]"  -skip="\[Flaky\]|\[Slow\]|\[Serial\]"  --no-color -v --timeout=30m ./e2e_node.test -- --system-spec-name= --system-spec-file= --extra-envs= --runtime-config= --v 4 --node-name=n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5 --report-dir=/tmp/node-e2e-20241123T111515/results --report-prefix=fedora --image-description="fedora-coreos-41-20241027-3-0-gcp-x86-64" --kubelet-flags="--cluster-domain=cluster.local" --dns-domain="cluster.local" --prepull-images=false  --container-runtime-endpoint=unix:///run/containerd/containerd.sock --ginkgo.timeout=3h --container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}" 2>&1 | tee -i /tmp/node-e2e-20241123T111515/results/n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5-ginkgo.log'] failed with error: exit status 1

Failing jobs:

• https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-crio-cgrpv2-imagefs-e2e-kubetest2/1860277072312668160
• https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-crio-cgrpv2-splitfs-e2e-kubetest2/1855229748838404096#

[aojea]

I was checking the linked jobs history and I don't see any failure related to the --container-runtime-endpoint option, it actually seems the test work correctly without setting that option ... can you elaborate more on what is the specific problem of not setting this flag?