Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --container-runtime-endpoint for node tester #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add --container-runtime-endpoint for node tester #280

wants to merge 1 commit into from
+2 −0

Conversation

elieser1101
Copy link
Contributor

Fixes #279

Pass the CONTAINER_RUNTIME_ENDPOINT so the makefile can set up properly the value.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elieser1101
Once this PR has been reviewed and has the lgtm label, please assign xmcqueen for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@aojea
Copy link
Contributor

aojea commented Nov 26, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2024
@elieser1101
Copy link
Contributor Author

/test pull-kubetest2-gce-node-e2e
/test pull-kubetest2-gke-up-down-multicluster

@aojea
Copy link
Contributor

aojea commented Nov 26, 2024

@elieser1101 where you able to validate manually that this works correctly?

@elieser1101
Copy link
Contributor Author

I was able to validate locally that the value get replaced when passed and kept the default /run/containerd/containerd.sock when the flag is not set

@aojea
Copy link
Contributor

aojea commented Nov 26, 2024

I was able to validate locally that the value get replaced when passed and kept the default /run/containerd/containerd.sock when the flag is not set

/hold

#279 (comment)

It does not seem necessary to set this flag, at least I can not find the impact of not setting it, I also see some jobs passing on the history

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@aojea
Copy link
Contributor

aojea commented Nov 26, 2024

If I take this job per example https://storage.googleapis.com/kubernetes-ci-logs/pr-logs/pull/128092/pull-kubernetes-node-crio-cgrpv2-imagefs-e2e-kubetest2/1860277072312668160/artifacts/n1-standard-2-fedora-coreos-41-20241027-3-0-gcp-x86-64-1037a7f5/kubelet.log

I can see how kubelet starts with the right value

I1123 11:15:37.951691 3541 flags.go:64] FLAG: --container-runtime-endpoint="unix:///var/run/crio/crio.sock"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing --container-runtime-endpoint flag
3 participants
@elieser1101 @k8s-ci-robot @aojea