From c78609d0f3c649786328ca4bca02fffa6c31a59d Mon Sep 17 00:00:00 2001 From: David Grove Date: Tue, 21 Jan 2025 16:37:47 -0500 Subject: [PATCH] comment out partial managedBy logic --- .../appwrapper_multikueue_adapter.go | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/pkg/controller/jobs/appwrapper/appwrapper_multikueue_adapter.go b/pkg/controller/jobs/appwrapper/appwrapper_multikueue_adapter.go index 1911256f28..1db81eed21 100644 --- a/pkg/controller/jobs/appwrapper/appwrapper_multikueue_adapter.go +++ b/pkg/controller/jobs/appwrapper/appwrapper_multikueue_adapter.go @@ -26,7 +26,6 @@ import ( "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/klog/v2" - "k8s.io/utils/ptr" ctrl "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" @@ -106,16 +105,19 @@ func (b *multikueueAdapter) KeepAdmissionCheckPending() bool { } func (b *multikueueAdapter) IsJobManagedByKueue(ctx context.Context, c client.Client, key types.NamespacedName) (bool, string, error) { - aw := awv1beta2.AppWrapper{} - err := c.Get(ctx, key, &aw) - if err != nil { - return false, "", err - } - awControllerName := ptr.Deref(aw.Spec.ManagedBy, "") - if awControllerName != kueue.MultiKueueControllerName { - return false, fmt.Sprintf("Expecting spec.managedBy to be %q not %q", kueue.MultiKueueControllerName, awControllerName), nil - } return true, "", nil + /* + aw := awv1beta2.AppWrapper{} + err := c.Get(ctx, key, &aw) + if err != nil { + return false, "", err + } + awControllerName := ptr.Deref(aw.Spec.ManagedBy, "") + if awControllerName != kueue.MultiKueueControllerName { + return false, fmt.Sprintf("Expecting spec.managedBy to be %q not %q", kueue.MultiKueueControllerName, awControllerName), nil + } + return true, "", nil + */ } var _ jobframework.MultiKueueWatcher = (*multikueueAdapter)(nil)