Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to install lws at user specified namespace #215

Closed
1 of 3 tasks
Tracked by #221
kerthcet opened this issue Sep 13, 2024 · 5 comments · Fixed by #226
Closed
1 of 3 tasks
Tracked by #221

Support to install lws at user specified namespace #215

kerthcet opened this issue Sep 13, 2024 · 5 comments · Fixed by #226
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kerthcet
Copy link
Contributor

What would you like to be added:

Hope to install lws at a configurable namespace rather than the hardcode lws-system.

Here's a code snippet we need to care about: https://github.com/kubernetes-sigs/lws/blob/main/pkg/cert/cert.go#L27

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@kerthcet kerthcet added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 13, 2024
@googs1025
Copy link
Member

/assign
I understand that we need to provide a configurable namespace right?

@liurupeng
Copy link
Collaborator

+1 to the proposal

@googs1025
Copy link
Member

#170

Is it consistent with this issue?

@googs1025
Copy link
Member

/unassign

@kerthcet
Copy link
Contributor Author

Yes, this should be part of the CC, would you like to take it over @googs1025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants