Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System metrics support #87

Open
1 of 3 tasks
Tracked by #221
kerthcet opened this issue Apr 9, 2024 · 9 comments
Open
1 of 3 tasks
Tracked by #221

System metrics support #87

kerthcet opened this issue Apr 9, 2024 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kerthcet
Copy link
Contributor

kerthcet commented Apr 9, 2024

What would you like to be added:

We should add some metrics for tracking the health of the system, some of them like:

  • Rolling update duration
  • Recreate group times
  • HPA related? Like scaling up/down times & duration?

Please add more if you think so.

Why is this needed:

Providing insight of the system

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@kerthcet kerthcet added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2024
@liurupeng
Copy link
Collaborator

+1 this should be pretty useful. How about "latency for pod be scheduled and become ready"?

@kerthcet
Copy link
Contributor Author

kerthcet commented Apr 9, 2024

Or do you mean Replica? Pod seems not that important.

@liurupeng
Copy link
Collaborator

Or do you mean Replica? Pod seems not that important.

yep, Replica makes sense

@Edwinhr716
Copy link
Contributor

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2024
@kerthcet
Copy link
Contributor Author

kerthcet commented Jul 9, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2024
@googs1025
Copy link
Member

"Hey, do we still need this feature? I'm not sure why the PR got closed back then and nothing happened afterwards. If it is still needed, I can take a shot at it." @kerthcet @liurupeng @Edwinhr716
Or, it would be great if Edwinhr716 is willing to re-promote this PR

@Edwinhr716
Copy link
Contributor

The PR got closed due to lack of clarity on what each metric was measuring. If we want to continue with the issue, it would be good to agree on what metrics we want to be added and what each metric entails

@kerthcet
Copy link
Contributor Author

Yes, we do. I'll categorize them once I had time and submit a pr as a demo.

@Edwinhr716 Edwinhr716 removed their assignment Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants