diff --git a/conformance/utils/suite/conformance_profiles.go b/conformance/utils/suite/conformance_profiles.go index e8433eb9..86acdfaf 100644 --- a/conformance/utils/suite/conformance_profiles.go +++ b/conformance/utils/suite/conformance_profiles.go @@ -61,8 +61,6 @@ var ( ), ExtendedFeatures: sets.New( SupportAdminNetworkPolicyNamedPorts, - SupportAdminNetworkPolicySameLabels, - SupportAdminNetworkPolicyNotSameLabels, ), } @@ -74,8 +72,6 @@ var ( ), ExtendedFeatures: sets.New( SupportBaselineAdminNetworkPolicyNamedPorts, - SupportBaselineAdminNetworkPolicySameLabels, - SupportBaselineAdminNetworkPolicyNotSameLabels, ), } ) diff --git a/conformance/utils/suite/features.go b/conformance/utils/suite/features.go index 5b8af6fd..d68cd73b 100644 --- a/conformance/utils/suite/features.go +++ b/conformance/utils/suite/features.go @@ -38,7 +38,7 @@ const ( ) // CoreFeatures are the features that are required to be conformant with -// the Core API features (e.g. all fields in the API except for NamedPorts, SameLabels, NotSameLabels). +// the Core API features (e.g. all fields in the API except for NamedPorts). var CoreFeatures = sets.New( SupportAdminNetworkPolicy, SupportBaselineAdminNetworkPolicy, @@ -49,25 +49,17 @@ var CoreFeatures = sets.New( // ----------------------------------------------------------------------------- const ( - // This option indicates AdminNetworkPolicy's NamedPorts, SameLabels and NotSameLabels + // This option indicates AdminNetworkPolicy's NamedPorts // fall under the extended test conformance. SupportAdminNetworkPolicyNamedPorts SupportedFeature = "AdminNetworkPolicyNamedPorts" - SupportAdminNetworkPolicySameLabels SupportedFeature = "AdminNetworkPolicySameLabels" - SupportAdminNetworkPolicyNotSameLabels SupportedFeature = "AdminNetworkPolicyNotSameLabels" SupportBaselineAdminNetworkPolicyNamedPorts SupportedFeature = "BaselineAdminNetworkPolicyNamedPorts" - SupportBaselineAdminNetworkPolicySameLabels SupportedFeature = "BaselineAdminNetworkPolicySameLabels" - SupportBaselineAdminNetworkPolicyNotSameLabels SupportedFeature = "BaselineAdminNetworkPolicyNotSameLabels" ) // ExtendedFeatures are extra generic features that implementations may // choose to support as an opt-in. var ExtendedFeatures = sets.New( SupportAdminNetworkPolicyNamedPorts, - SupportAdminNetworkPolicySameLabels, - SupportAdminNetworkPolicyNotSameLabels, SupportBaselineAdminNetworkPolicyNamedPorts, - SupportBaselineAdminNetworkPolicySameLabels, - SupportBaselineAdminNetworkPolicyNotSameLabels, ).Insert(CoreFeatures.UnsortedList()...) // ----------------------------------------------------------------------------- diff --git a/pkg/generator/main.go b/pkg/generator/main.go index d91b5314..0ffcefb4 100644 --- a/pkg/generator/main.go +++ b/pkg/generator/main.go @@ -107,7 +107,7 @@ func main() { channelCrd := crdRaw.DeepCopy() for _, version := range channelCrd.Spec.Versions { version.Schema.OpenAPIV3Schema.Properties = channelTweaks(channel, version.Schema.OpenAPIV3Schema.Properties) - if _, ok := version.Schema.OpenAPIV3Schema.Properties["notSameLabels"]; ok { + if _, ok := version.Schema.OpenAPIV3Schema.Properties["namedPort"]; ok { fmt.Println("Changes not persisted") } } diff --git a/site-src/user-story-examples/user-story-4-v1.yaml b/site-src/user-story-examples/user-story-4-v1.yaml index 2f3c856c..cb7086c8 100644 --- a/site-src/user-story-examples/user-story-4-v1.yaml +++ b/site-src/user-story-examples/user-story-4-v1.yaml @@ -12,5 +12,5 @@ spec: - action: Deny from: - namespaces: - notSameLabels: - - tenant + # This user story is currently not implementable. + # See https://network-policy-api.sigs.k8s.io/npeps/npep-122/ for more details. diff --git a/site-src/user-story-examples/user-story-4-v2.yaml b/site-src/user-story-examples/user-story-4-v2.yaml index 405060c6..e2cd4d32 100644 --- a/site-src/user-story-examples/user-story-4-v2.yaml +++ b/site-src/user-story-examples/user-story-4-v2.yaml @@ -11,8 +11,8 @@ spec: - action: Pass # Pass inter-tenant traffic to any defined NetworkPolicies from: - namespaces: - sameLabels: - - tenant + # This user story is currently not implementable. + # See https://network-policy-api.sigs.k8s.io/npeps/npep-122/ for more details. - action: Deny # Deny everything else other than same tenant traffic from: - namespaces: