Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFORMANCE] Use kube-network-policies to run conformance tests in the CI #225

Closed
tssurya opened this issue Apr 25, 2024 · 11 comments
Closed
Labels
area/conformance Issues or PRs related to conformance testing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@tssurya
Copy link
Contributor

tssurya commented Apr 25, 2024

Why this is needed:

We need to use https://github.com/kubernetes-sigs/kube-network-policies now that we have an implementation that will help us catch CI flakes and improve our testing framework

thanks @aojea for the awesome work here. Definitely helps having a non-vendor implementation based CI runs that we can play with and maintain

TODO: Add a CI lane for this

@tssurya tssurya added the area/conformance Issues or PRs related to conformance testing label Apr 25, 2024
@aojea
Copy link
Contributor

aojea commented Apr 25, 2024

It is already merged, isn't it ?

#224

@astoycos
Copy link
Member

I think @tssurya meant we should be running the core K8s network policy tests on the network-policy-api repo as well as in the core prow instance so that we can easily see if anything is broken/ go fix it

At the very least it'd be nice for us to be alerted if something was broken with the core tests so that we could assist in fixing them, since part of our charter is "maintaining the in-tree NetworkPolicy resource/tests"

@aojea
Copy link
Contributor

aojea commented Apr 25, 2024

you mean set a periodic job in prow?

@astoycos
Copy link
Member

I was thinking run the core netpol tests against kube-network-policies in our github actions alongside the tests for ANP + BANP

But maybe Surya had something else in mind here?

@aojea
Copy link
Contributor

aojea commented Apr 25, 2024

kube-network-policies is used for kubernetes CI , periodic and presubmit

https://testgrid.k8s.io/sig-network-gce#network-policies,%20google-gce&width=20
https://testgrid.k8s.io/sig-network-gce#presubmit-network-policies,%20google-gce&width=20

There is a flake with one specific test , I'm investigating it here kubernetes-sigs/kube-network-policies#12, but it seems some kernel or OS thing

but there are zero flakes on the github actions in kube-network-policies

@aojea
Copy link
Contributor

aojea commented Apr 26, 2024

I don't fully understand but happy to help or discuss

@tssurya
Copy link
Contributor Author

tssurya commented Apr 26, 2024

yes exactly what was done in #224 except I didn't see that PR :) Andrew merged it too quick haha
my plan was to use kube-network-policies for running e2e's tests in this repo for presubmits. (when we add new tests here in this repo or change some framework we don't have presubmits that tests the changes against PRs, that was my goal here)

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Issues or PRs related to conformance testing lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants