You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The filter logic currently available, filters the labels that gets added to the node. But, the nodefeature object is still big, with all the feature attributes added to the NodeFeature.
:
For example, we added labelSource and label white lists to get the feature flags for these PCI devices as below:
But, the pci devices and attributes in the NodeFetaure is quite large and lists hundreds of devices we don't care about. We wanted to support this feature.
Another example:
Obviously the ability to filter would be different for each feature. As another example, the kernel feature is also quite large (several thousand lines), when we may only care about one or two flags for labels - kernel version in our case.
This means we need to enable kernel feature, which is very large as well.
The text was updated successfully, but these errors were encountered:
Also, one possible easy and huge optimization for the pci devices would be to group identical entries. Now we list everything, if you have say 50 virtual functions of certain device we list 50 identical entries -> does not make sense to me. We could group those and add new attribute like count or numEntries or whatever. I think that alone would reduce the data immensely without actually filtering out anything. For kernel config options we need filtering, though.
What would you like to be added:
Add logic to filter the "features" that gets added to the nodefeature object.
node-feature-discovery/pkg/nfd-worker/nfd-worker.go
Line 668 in d7257a9
Why is this needed:
The filter logic currently available, filters the labels that gets added to the node. But, the nodefeature object is still big, with all the feature attributes added to the NodeFeature.
:
For example, we added labelSource and label white lists to get the feature flags for these PCI devices as below:
labels:
feature.node.kubernetes.io/pci-0300_1a03.present: "true"
But, the pci devices and attributes in the NodeFetaure is quite large and lists hundreds of devices we don't care about. We wanted to support this feature.
Another example:
Obviously the ability to filter would be different for each feature. As another example, the kernel feature is also quite large (several thousand lines), when we may only care about one or two flags for labels - kernel version in our case.
This means we need to enable kernel feature, which is very large as well.
The text was updated successfully, but these errors were encountered: