Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Policy field optional and eventually deprecate/remove it from the AppArmorProfile CR #2388

Open
ccojocar opened this issue Jul 31, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ccojocar
Copy link
Contributor

What would you like to be added:

The Policy field was originally introduced to store the raw apparmor profile installed by the operator. Later, a new field Abstract was additionally added. The later defines a detailed schema of the apparmor profile. This looks like a duplication in the API which can lead to complications and out of sync data.

At the moment, the Policy is a requied field in the AppArmorProfile CR definition. This make the Policy field mandatory, otherwise the API validation will fail before reaching the operator.

The plan is to make this optional, and use the abstract as a source for apparmor profiles. The raw profile can be generated on the fly by the operator when the Policy field is empty.

Eventually, we should deprecate and remove the policy field. Not sure, what is the impact of directly removing it. This can break the cluster where apparmor profile is installed via the Policy field.

Why is this needed:

Improve the ApparmorPolicy API by removing data duplication.

User story covered

@ccojocar ccojocar added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2024
mhils added a commit to mhils/security-profiles-operator that referenced this issue Aug 26, 2024
k8s-ci-robot pushed a commit that referenced this issue Sep 2, 2024
mhils added a commit to mhils/security-profiles-operator that referenced this issue Oct 1, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2024
@ccojocar
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants