Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PV Protection breaks deleting #5

Closed
rmb938 opened this issue Dec 21, 2018 · 2 comments
Closed

PV Protection breaks deleting #5

rmb938 opened this issue Dec 21, 2018 · 2 comments

Comments

@rmb938
Copy link
Contributor

rmb938 commented Dec 21, 2018

If a user deletes a PV while it has a PVC with a pv protection finalizer the CSI never gets alerted to delete the volume when the pvc is deleted.

Related Issue: kubernetes-csi/external-provisioner#195

It seems like https://github.com/kubernetes-sigs/sig-storage-lib-external-provisioner/blob/master/controller/controller.go#L860 is the problem.

Without a fix it is very easy for a user to delete a pv and break deleting via the CSI.
@msau42
Copy link

msau42 commented Dec 21, 2018

cc @wongma7 @jsafrane

@rmb938
Copy link
Contributor Author

rmb938 commented Dec 21, 2018 •
edited
Loading

It probably would be useful to add an external-provisioner finalizer and check for the existence of that. If it exists then try to delete the pv, if it succeeds then remove the finalizer. If it doesn't exist return false as normal.

rmb938 added a commit to rmb938/sig-storage-lib-external-provisioner that referenced this issue Dec 21, 2018
@rmb938
fixes kubernetes-sigs#5, add a finalizer to fix deletion during pv pr…
6cd5373 
…otection
@rmb938 rmb938 mentioned this issue Dec 21, 2018
Merged
rmb938 added a commit to rmb938/sig-storage-lib-external-provisioner that referenced this issue Dec 21, 2018
@rmb938
fixes kubernetes-sigs#5, add a finalizer to fix deletion during pv pr…
00f37cf 
…otection
wongma7 pushed a commit to wongma7/sig-storage-lib-external-provisioner that referenced this issue Dec 21, 2018
@rmb938 @wongma7
fixes kubernetes-sigs#5, add a finalizer to fix deletion during pv pr…
387f862 
…otection
k8s-ci-robot added a commit that referenced this issue Jan 7, 2019
@k8s-ci-robot
Merge pull request #6 from rmb938/customfinalizer
844c30e 
fixes #5, add a finalizer to fix deletion during pv protection
@wongma7 wongma7 mentioned this issue Jan 23, 2019
Closed
@wongma7 wongma7 mentioned this issue Apr 8, 2019
Closed
humblec pushed a commit to humblec/sig-storage-lib-external-provisioner that referenced this issue Jun 18, 2020
@k8s-ci-robot
Merge pull request kubernetes-sigs#5 from pohly/test-enhancements
33d58fd 
test enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmb938 @msau42