Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: TestMetricsNodeSamplerGRPC/basic #126

Open
ehashman opened this issue Mar 7, 2024 · 1 comment
Open

Flaky test: TestMetricsNodeSamplerGRPC/basic #126

ehashman opened this issue Mar 7, 2024 · 1 comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ehashman
Copy link
Contributor

ehashman commented Mar 7, 2024

Per https://testgrid.k8s.io/sig-instrumentation-usage-metrics-collector#periodic-test&width=20

sigs.k8s.io/usage-metrics-collector/cmd/metrics-node-sampler/integration.TestMetricsNodeSamplerGRPC/basic test is frequently flaking.

Example failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-usage-metrics-collector-test/1765441415891914752

    	            	Diff:
    	            	--- Expected
    	            	+++ Actual
    	            	@@ -169,2 +169,3 @@
    	            	 				"cpuCoresNanoSec": [
    	            	+					"1000",
    	            	 					"1000"
    	            	@@ -172,2 +173,3 @@
    	            	 				"memoryBytes": [
    	            	+					"0",
    	            	 					"0"
    	Test:       	TestMetricsNodeSamplerGRPC/basic
--- FAIL: TestMetricsNodeSamplerGRPC/basic (12.12s)

It appears there is an additional sample being returned vs. what's expected. Perhaps someone can look into why this is happening.
@ehashman ehashman added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. labels Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 7, 2024
@ehashman ehashman mentioned this issue Mar 7, 2024
Open
@ehashman
Copy link
Contributor Author

ehashman commented Apr 4, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/flake Categorizes issue or PR as related to a flaky test. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehashman @k8s-ci-robot