return struct

Author: jackfrancis

cluster-autoscaler/core/static_autoscaler.go

@@ -1162,12 +1162,12 @@ func listPods(podLister kube_util.PodLister, bypassedSchedulers map[string]bool)
 		klog.Errorf("Failed to list pods: %v", err)
 		return nil, nil, nil, err
 	}
-	scheduled, unschedulable, unprocessed = kube_util.FilterPodsBySchedulability(pods, bypassedSchedulers)
+	p := kube_util.ArrangePodsBySchedulability(pods, bypassedSchedulers)
 	// Skip logging in case of the boring scenario, when all pods are scheduled.
-	if len(pods) != len(scheduled) {
-		ignored := len(pods) - len(scheduled) - len(unschedulable) - len(unprocessed)
+	if len(pods) != len(p.Scheduled) {
+		ignored := len(pods) - len(p.Scheduled) - len(p.Unschedulable) - len(p.Unprocessed)
 		klog.Infof("Found %d pods in the cluster: %d scheduled, %d unschedulable, %d unprocessed by scheduler, %d ignored (most likely using custom scheduler)",
-			len(pods), len(scheduled), len(unschedulable), len(unprocessed), ignored)
+			len(pods), len(p.Scheduled), len(p.Unschedulable), len(p.Unprocessed), ignored)
 	}
 	return
 }

cluster-autoscaler/utils/kubernetes/listers.go

@@ -58,6 +58,13 @@ type listerRegistryImpl struct {
 	statefulSetLister           v1appslister.StatefulSetLister
 }
 
+// PodsBySchedulability is a struct that holds pods classified by their schedulability status.
+type PodsBySchedulability struct {
+	Scheduled     []*apiv1.Pod
+	Unschedulable []*apiv1.Pod
+	Unprocessed   []*apiv1.Pod
+}
+
 // NewListerRegistry returns a registry providing various listers to list pods or nodes matching conditions
 func NewListerRegistry(allNode NodeLister, readyNode NodeLister, allPodLister PodLister, podDisruptionBudgetLister PodDisruptionBudgetLister,
 	daemonSetLister v1appslister.DaemonSetLister, replicationControllerLister v1lister.ReplicationControllerLister,
@@ -139,7 +146,7 @@ func (r listerRegistryImpl) StatefulSetLister() v1appslister.StatefulSetLister {
 }
 
 // PodLister lists all pods.
-// To filter out scheduled, unschedulable, or unprocessed pods the helper method FilterPodsBySchedulability should be used.
+// To filter out scheduled, unschedulable, or unprocessed pods the helper method ArrangePodsBySchedulability should be used.
 type PodLister interface {
 	List() ([]*apiv1.Pod, error)
 }
@@ -168,28 +175,30 @@ func ScheduledPods(allPods []*apiv1.Pod) []*apiv1.Pod {
 	return scheduledPods
 }
 
-// FilterPodsBySchedulability is a helper method that returns all scheduled and unschedulable pods from given pod list.
-func FilterPodsBySchedulability(allPods []*apiv1.Pod, bypassedSchedulers map[string]bool) (scheduled, unschedulable, unprocessed []*apiv1.Pod) {
+// ArrangePodsBySchedulability is a helper method that classifies pods by scheduled, unschedulable,
+// and not processed by a scheduler from given pod list.
+func ArrangePodsBySchedulability(allPods []*apiv1.Pod, bypassedSchedulers map[string]bool) PodsBySchedulability {
+	var arranged PodsBySchedulability
 	for _, pod := range allPods {
 		if isScheduled(pod) {
-			scheduled = append(scheduled, pod)
+			arranged.Scheduled = append(arranged.Scheduled, pod)
 			continue
 		} else if isDeleted(pod) {
 			continue
 		} else {
 			_, condition := podv1.GetPodCondition(&pod.Status, apiv1.PodScheduled)
 			if !(condition == nil || condition.Status != apiv1.ConditionFalse || condition.Reason != apiv1.PodReasonUnschedulable) {
-				unschedulable = append(unschedulable, pod)
+				arranged.Unschedulable = append(arranged.Unschedulable, pod)
 			} else {
 				if canBypass := bypassedSchedulers[pod.Spec.SchedulerName]; canBypass {
 					if condition == nil || (condition.Status == apiv1.ConditionFalse && condition.Reason == "") {
-						unprocessed = append(unprocessed, pod)
+						arranged.Unprocessed = append(arranged.Unprocessed, pod)
 					}
 				}
 			}
 		}
 	}
-	return scheduled, unschedulable, unprocessed
+	return arranged
 }
 
 // SchedulingGatedPods is a helper method that returns all pods which has scheduling gate