Skip to content

Commit c857bb1

Browse files
pohlyk8s-publishing-bot
authored andcommitted
remove import doc comments
The "// import <path>" comment has been superseded by Go modules. We don't have to remove them, but doing so has some advantages: - They are used inconsistently, which is confusing. - We can then also remove the (currently broken) hack/update-vanity-imports.sh. - Last but not least, it would be a first step towards avoiding the k8s.io domain. This commit was generated with sed -i -e 's;^package \(.*\) // import.*;package \1;' $(git grep -l '^package.*// import' | grep -v 'vendor/') Everything was included, except for package labels // import k8s.io/kubernetes/pkg/util/labels because that package is marked as "read-only". Kubernetes-commit: 8a908e0c0bd96a3455edf7e3b5f5af90564e65b0
1 parent 8457d3b commit c857bb1

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

config/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ limitations under the License.
1616

1717
// +k8s:deepcopy-gen=package
1818

19-
package config // import "k8s.io/component-base/config"
19+
package config

config/v1alpha1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ limitations under the License.
1717
// +k8s:deepcopy-gen=package
1818
// +k8s:conversion-gen=k8s.io/component-base/config
1919

20-
package v1alpha1 // import "k8s.io/component-base/config/v1alpha1"
20+
package v1alpha1

doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/
1616

17-
package componentbase // import "k8s.io/component-base"
17+
package componentbase

logs/api/v1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ limitations under the License.
2929
// The LoggingAlphaOptions and LoggingBetaOptions feature gates control whether
3030
// these unstable features can get enabled. This can be used to ensure that
3131
// command invocations do not accidentally rely on unstable features.
32-
package v1 // import "k8s.io/component-base/logs/api/v1"
32+
package v1

tracing/api/v1/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,4 @@ limitations under the License.
2626
// The "v1" package name is just a reminder that API compatibility rules apply,
2727
// not an indication of the stability of all features covered by it.
2828

29-
package v1 // import "k8s.io/component-base/tracing/api/v1"
29+
package v1

0 commit comments

Comments
 (0)