Skip to content

Commit 4d27a7d

Browse files
committed
update label
Signed-off-by: Rita Zhang <[email protected]>
1 parent 420ef20 commit 4d27a7d

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

keps/sig-auth/5018-dra-adminaccess/README.md

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,11 @@ objects as privileged. This feature includes:
179179
```yaml
180180
metadata:
181181
labels:
182-
resource.k8s.io/admin-access: "true"
182+
resource.kubernetes.io/admin-access: "true"
183183
```
184184
185+
Note: This label has been updated from `resource.k8s.io/admin-access` while the feature was in alpha in v1.33.
186+
185187
Assumptions:
186188

187189
- It is not important to subdivide admin access to different types of
@@ -194,7 +196,7 @@ objects as privileged. This feature includes:
194196

195197
In the REST storage layer, validate requests to create and update
196198
`ResourceClaim` or `ResourceClaimTemplate` objects with `adminAccess: true`.
197-
Only authorize if namespace has the `resource.k8s.io/admin-access: "true"` label.
199+
Only authorize if namespace has the `resource.kubernetes.io/admin-access: "true"` label.
198200
199201
1. Grants privileged access to the requested device:
200202
@@ -212,7 +214,7 @@ objects as privileged. This feature includes:
212214
### Workflow
213215

214216
1. A cluster administrator labels an admin namespace with
215-
`resource.k8s.io/admin-access: "true"`.
217+
`resource.kubernetes.io/admin-access: "true"`.
216218
217219
1. Users who are authorized to create `ResourceClaim` or `ResourceClaimTemplate`
218220
objects in this admin namespace can set `adminAccess: true` field if they
@@ -284,7 +286,7 @@ shouldn't have allowed unrestricted access.
284286
Starting in Kubernetes 1.33 (when this KEP was introduced), a validation has
285287
been added to the REST storage layer to only authorize `ResourceClaim` or
286288
`ResourceClaimTemplate` with `adminAccess: true` requests if their namespace has
287-
the `resource.k8s.io/admin-access: "true"` label to only allow it for users with
289+
the `resource.kubernetes.io/admin-access: "true"` label to only allow it for users with
288290
additional privileges.
289291
290292
The below flowchart starts with `ResourceClaim` creation from
@@ -415,7 +417,7 @@ Those tests run in:
415417
- Additional test cases will be added to `test/integration/scheduler_perf` to
416418
ensure `ResourceClaim` or `ResourceClaimTemplate` with `adminAccess: true`
417419
requests are only authorized if their namespace has the
418-
`resource.k8s.io/admin-access: "true"` label as described in this KEP.
420+
`resource.kubernetes.io/admin-access: "true"` label as described in this KEP.
419421
420422
##### e2e tests
421423
@@ -436,7 +438,7 @@ was developed as part of the overall DRA development effort. We have extended
436438
this test driver to enable `DRAAdminAccess` feature gate and added tests to
437439
ensure `ResourceClaim` or `ResourceClaimTemplate` with `adminAccess: true`
438440
requests are only authorized if their namespace has the
439-
`resource.k8s.io/admin-access: "true"` label as described in this KEP.
441+
`resource.kubernetes.io/admin-access: "true"` label as described in this KEP.
440442
441443
Test links:
442444
@@ -798,7 +800,7 @@ For each of them, fill in the following information by copying the below templat
798800
To troubleshoot, "kubectl describe" can be used on (in this order) Pod
799801
and ResourceClaim.
800802

801-
- Mitigations: When ResourceClaims or ResourceClaimTemplates the `AdminAccess`
803+
- Mitigations: When ResourceClaims or ResourceClaimTemplates with the `AdminAccess`
802804
field don't get created, debugging should focus on the namespace labels. The kube-controller-manager logs should have more information.
803805

804806
- Diagnostics: Audit Policy can be created to ensure all create operations on ResourceClaim, ResourceClaimTemplate, and Namespace resources are logged at the metadata level to review successful and denied attempts to set the `AdminAccess`

0 commit comments

Comments
 (0)