Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes-etcd interface #4743

Open
serathius opened this issue Jun 28, 2024 · 13 comments
Open

Kubernetes-etcd interface #4743

serathius opened this issue Jun 28, 2024 · 13 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd.

Comments

@serathius
Copy link
Contributor

serathius commented Jun 28, 2024

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 28, 2024
@serathius
Copy link
Contributor Author

/sig etcd
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 28, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Sep 23, 2024

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 23, 2024
@tjons
Copy link
Contributor

tjons commented Sep 29, 2024

Hi @serathius @jpbetz - enhancements lead here. Is this proposal targeting a specific stage in 1.32? This proposal seems like a bit of a "special snowflake" compared to most and I'm not sure how we should track it.

Thanks!

@serathius
Copy link
Contributor Author

Usually SIG-etcd don't touch K8s meaning that we don't need to adhere to K8s release process, however here it's we are making changes to K8s so I think it's ok to track it.

@tjons
Copy link
Contributor

tjons commented Oct 4, 2024

ok - what stage are you targeting in 1.32? alpha/beta/stable?

@jpbetz
Copy link
Contributor

jpbetz commented Oct 4, 2024

This is the first release for this, so it should be alpha.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 4, 2024

@tjons Can you help me compile a list of what we need to have in place for this KEP to make sure it's ready for enhancements freeze? I'm happy with it technically. I see PRR is missing. What else do you see missing from the sig-release checklist?

@tjons
Copy link
Contributor

tjons commented Oct 6, 2024

@jpbetz sorry, just saw this. As we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024, this enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@serathius
Copy link
Contributor Author

Sorry for confusion, I think we will want to opt-out from this KEP being tracked. Reasons:

  • There is no user facing change, just a refactor to align internal apiserver code to match an interface.
  • We created a KEP just to document the decision and collect consensus.
  • There is no need to broadly announce the change

I thought it would be good to be tracked, as the work will take some time to finish and it would be useful to track progress across multiple K8s versions, however the overhead of KEP template, PRR and other processes makes it not worth it.

@serathius
Copy link
Contributor Author

/milestone-clear

@deads2k
Copy link
Contributor

deads2k commented Oct 7, 2024

Sorry for confusion, I think we will want to opt-out from this KEP being tracked. Reasons:

I agree, this doesn't need PRR. I'm glad we got a good description of our goals and reasoning in the enhancements repo

@jpbetz jpbetz removed this from the v1.32 milestone Oct 10, 2024
@dipesh-rawat
Copy link
Member

Hello @serathius 👋, 1.32 Enhancements team here.

Since this enhancement has been opted out from the current v1.32 milestone, it's now marked as Deferred for the current v1.32 release cycle. Confirming this based on the comment #4743 (comment). Thanks!

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 10, 2024
@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

/milestone clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd.
Projects
Status: Deferred
Development

No branches or pull requests

6 participants