Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent container ready state after kubelet restart #4781

Open
4 tasks
pololowww opened this issue Aug 7, 2024 · 12 comments
Open
4 tasks

Fix inconsistent container ready state after kubelet restart #4781

pololowww opened this issue Aug 7, 2024 · 12 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@pololowww
Copy link

pololowww commented Aug 7, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 7, 2024
@HirazawaUi
Copy link
Contributor

Is this a duplicate of #4761?

@songminglong
Copy link

I agree that when kubelet restarts, the container state should be kept consistent. Pulling in and out is detrimental to the application and is not conducive to kubelet upgrades. We fixed this situation ourselves

@kannon92
Copy link
Contributor

Please update the description with your PR.

@kannon92
Copy link
Contributor

Given the reviews on the KEP, I'm moving this to proposed for consideration. Please sign the CLA.

@pololowww
Copy link
Author

Given the reviews on the KEP, I'm moving this to proposed for consideration. Please sign the CLA.

Thanks, signed already:)

@haircommander
Copy link
Contributor

/assign @pololowww

@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 1, 2024
@dipesh-rawat
Copy link
Member

Hello @pololowww 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise)

/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 1, 2024
@pololowww
Copy link
Author

  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

@dipesh-rawat Many thanks for reminding me of the deadline, but i think that the KEP4781 is not merged yet.#4784
Could you please let me know what i should do to ensure everything is on track?

@dipesh-rawat
Copy link
Member

Hi @pololowww 👋, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #4781 (comment) that still need to be completed.

It looks like PR #4784 will address most of these issues. The PR #4784 needs to be merged before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

Hello 👋, v1.32 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Status: Removed
Development

No branches or pull requests

8 participants