Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[global-rate-limit] [memcached] cant put more then 1 host #6849

Closed
kfirfer opened this issue Feb 4, 2021 · 12 comments
Closed

[global-rate-limit] [memcached] cant put more then 1 host #6849

kfirfer opened this issue Feb 4, 2021 · 12 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kfirfer
Copy link

kfirfer commented Feb 4, 2021

Hello,

When I try to put more than 1 memcached host, the global rate limit isn't working and doesn't communicate with memcached instance(s)

Configmap:

    global-rate-limit-memcached-host: "memcached-stack-0.memcached-stack.ingress-nginx.svc.cluster.local,memcached-stack-1.memcached-stack.ingress-nginx.svc.cluster.local"
    global-rate-limit-memcached-port: "11211"

App version: 0.44.0
Helm chart version: 3.23.0

@kfirfer kfirfer added the kind/bug Categorizes issue or PR as related to a bug. label Feb 4, 2021
@aledbf
Copy link
Member

aledbf commented Feb 4, 2021

/assign @ElvinEfendi

@ElvinEfendi
Copy link
Member

ElvinEfendi commented Feb 5, 2021

Hey @kfirfer, we rely on https://github.com/openresty/lua-resty-memcached which does not support clustering and also it seems like it will never does given author's this thought: openresty/lua-resty-memcached#18 (comment)

The underlying library ingress-nginx uses for global throttle is https://github.com/ElvinEfendi/lua-resty-global-throttle. I'll create an issue there to implement clustering using https://github.com/openresty/lua-resty-balancer/blob/master/lib/resty/chash.lua. Feel free to send a patch.

EDIT: I created the issue in the upstream library: ElvinEfendi/lua-resty-global-throttle#27

@kfirfer
Copy link
Author

kfirfer commented Feb 5, 2021

@ElvinEfendi
Thanks for clarification !

@ElvinEfendi
Copy link
Member

np @kfirfer !

This should not be labelled as a bug though. The feature never advertised that it supports clustered memcached.

@kfirfer
Copy link
Author

kfirfer commented Feb 6, 2021

@ElvinEfendi
You right, I don't know how to change labels =X

@ElvinEfendi
Copy link
Member

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2021
@iamNoah1
Copy link
Contributor

iamNoah1 commented Jul 7, 2021

/kind design

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Jul 7, 2021
@iamNoah1
Copy link
Contributor

iamNoah1 commented Jul 7, 2021

/remove-kind design
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/design Categorizes issue or PR as related to design. labels Jul 7, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2021
@iamNoah1
Copy link
Contributor

@kfirfer is this still relevant for you?

@iamNoah1
Copy link
Contributor

/close

Closing due to inactivity. Feel free to open a new issue.

@k8s-ci-robot
Copy link
Contributor

@iamNoah1: Closing this issue.

In response to this:

/close

Closing due to inactivity. Feel free to open a new issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants