-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch default OTel sampler to TraceIdRatioBased #12450
base: main
Are you sure you want to change the base?
Switch default OTel sampler to TraceIdRatioBased #12450
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: GFriedrich The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The committers listed above are authorized under a signed CLA. |
Welcome @GFriedrich! |
Hi @GFriedrich. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/kind feature |
What this PR does / why we need it:
AlwaysOn
toTraceIdRatioBased
, which is a more sane default in regards to loadTypes of changes
Which issue/s this PR fixes
fixes #12443
fixes #12432
How Has This Been Tested?
Checked that the default generated config files contains the expected configuration.
Checklist: