Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install command for Digial Ocean #5474

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Add install command for Digial Ocean #5474

merged 1 commit into from
Apr 29, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 29, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #3996

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@aledbf aledbf merged commit e1e8621 into kubernetes:master Apr 29, 2020
@aledbf aledbf deleted the do branch April 29, 2020 23:05
@rihardsgrislis
Copy link
Contributor

@aledbf if I previously used https://raw.githubusercontent.com/kubernetes/ingress-nginx/nginx-0.33.0/deploy/static/mandatory.yaml to install ingress-nginx do I need to run kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v0.34.1/deploy/static/provider/do/deploy.yaml now to fill some gaps/get correct stuff or I can just change the version of the image in the controller Deployment as always?

@aledbf
Copy link
Member Author

aledbf commented Jul 16, 2020

@rihardssceredins the idea is to use the static of the provider (if there is one). We tried to provide just one file to simplify the steps required to install the ingress controller.

now to fill some gaps/get correct stuff or I can just change the version of the image in the controller Deployment as always?

If you use https://raw.githubusercontent.com/kubernetes/ingress-nginx/controller-v0.34.1/deploy/static/provider/do/deploy.yaml you can run a diff and see if only the images are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DO Proxy Protocol broken header
3 participants