Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric(s) for KSM errors #2472

Open
rexagod opened this issue Aug 13, 2024 · 2 comments
Open

Add metric(s) for KSM errors #2472

rexagod opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@rexagod
Copy link
Member

rexagod commented Aug 13, 2024

          Seconding Damien, I'm not for panicking the binary since we expect a [reload](https://github.com/kubernetes/kube-state-metrics/blob/f8aa7d9bb9d8e29876e19f4859391a54a7e61d63/internal/wrapper.go#L61-L62) on configuration change, and then a log (or metric) indicating an issue with the given configuration. Crashing the binary goes against the controller-esque behavior and allows anyone (with access) to crash a running instance simply by supplying a bad config.

That said I can definitely see a pain point here and maybe we should add a new metrics to report any kind of misconfiguration so that it would be more visible to cluster admin when kube-state-metrics is misconfigured.

+1 all the way. I'll add one.

Originally posted by @rexagod in #2434 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 13, 2024
@rexagod
Copy link
Member Author

rexagod commented Aug 13, 2024

Not sure how this never came up until now, this seems like a good addition addition for telemetry.

@logicalhan
Copy link
Member

/triage accepted
/assign @rexagod

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants