Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang tests should not mutate k/k sources so we know what commit was tested #3146

Open
BenTheElder opened this issue Jan 31, 2025 · 2 comments · May be fixed by #3244
Open

golang tests should not mutate k/k sources so we know what commit was tested #3146

BenTheElder opened this issue Jan 31, 2025 · 2 comments · May be fixed by #3244
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@BenTheElder
Copy link
Member

We should probably use GOTOOLCHAIN=local instead of

perf-tests/golang/build-kubernetes.sh

Line 64 in 4c5c681

sed -i 's#FROM .*#FROM gcr.io/k8s-testimages/kube-cross-amd64:latest-go-master-debian-default#' Dockerfile

cc @dims @liggitt
@BenTheElder BenTheElder added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2025
@BenTheElder BenTheElder mentioned this issue Jan 31, 2025
Closed
@BenTheElder
Copy link
Member Author

The current approach is also fragile against any changes in the upstream build, but we have supported overriding the desired go version via environment variables for a while now, I think that should be sufficient?

@BenTheElder
Copy link
Member Author

cc @tosi3k @rf232 (and xref kubernetes/test-infra#34237 / kubernetes/test-infra#34246 (comment))

@BenTheElder BenTheElder mentioned this issue Feb 12, 2025
Open
@tosi3k tosi3k linked a pull request Mar 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update golang scripts tosi3k/perf-tests
1 participant
@BenTheElder