Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label kubernetes.io/cluster-trust-bundle-version not documented #41481

Open
sftim opened this issue Jun 5, 2023 · 14 comments
Open

Label kubernetes.io/cluster-trust-bundle-version not documented #41481

sftim opened this issue Jun 5, 2023 · 14 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Jun 5, 2023

This is a Bug Report

Problem:
Prompted by https://github.com/kubernetes/enhancements/pull/3913/files#r1142389497, I'm suggesting we might
need to document the label kubernetes.io/cluster-trust-bundle-version

Proposed Solution:

  1. Check if this label is used in any shipped Kubernetes code. If it is, even behind a feature gate, we must document it.
  2. If so, get it registered and documented.

Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:
/language en

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 5, 2023
@Shubham82
Copy link
Contributor

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jun 6, 2023
@enj enj added this to SIG Auth Jun 6, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Auth Jun 6, 2023
@stlaz
Copy link
Member

stlaz commented Jul 17, 2023

/triage accepted
in case the enhancement merges and the label is added

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 17, 2023
@stlaz stlaz moved this from Needs Triage to Backlog in SIG Auth Jul 17, 2023
@coder12git
Copy link
Contributor

/assign

@coder12git
Copy link
Contributor

Hey @sftim , according to above comment, seems like i can work on this issue only when this PR merges, is it?

@sftim
Copy link
Contributor Author

sftim commented Dec 27, 2023

Here's what we need to do, right now:

  1. Check if this label is used in any shipped Kubernetes code. If it is, even behind a feature gate, we must document it.
  2. If so, get it registered and documented.

Maybe the first step ends with finding that the label isn't used; if so, we're done (for now).

@coder12git coder12git removed their assignment Dec 28, 2023
@Ritikaa96
Copy link
Contributor

The PR has been merged but as per my search results there hasn't been any implementation of this label in the shipped code yet.
One occurrence is in the KEP it self.

@sftim
Copy link
Contributor Author

sftim commented Jul 1, 2024

As a final cleanup, I suggest opening a PR to change the KEP.

Revise kubernetes.io/cluster-trust-bundle-version to be, eg, k8s.example/cluster-trust-bundle-version and check that the use in the KEP is just an example. Then we're done done.

@Ritikaa96
Copy link
Contributor

Hi, so is it just a suggestion or we can raise PR to change the label in the KEP-3257?
I'll be happy to make the change just need a confirmation to change page: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3257-cluster-trust-bundles

@sftim
Copy link
Contributor Author

sftim commented Nov 14, 2024

Raising a PR sounds fine @Ritikaa96

@Ritikaa96
Copy link
Contributor

As per discussion this label is being updated in the KEP itself in PR: kubernetes/enhancements#4971

@Ritikaa96
Copy link
Contributor

Hi @sftim as per kubernetes/enhancements#4971 discussion this was used for example only so are we still waiting for its future usage?

@Ritikaa96
Copy link
Contributor

I rechecked and didn't find a usage too so can we close this?

@sftim
Copy link
Contributor Author

sftim commented Jan 30, 2025

@Ritikaa96 do you recommend closing the issue?

@Ritikaa96
Copy link
Contributor

Ritikaa96 commented Feb 7, 2025

@Ritikaa96 do you recommend closing the issue?

Hi @sftim I dont think i can decide that it is needed to be closed. I'm asking if there is anything pending for this issue before it get resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

6 participants