Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner for KubeCon India 2024 #48862

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Add banner for KubeCon India 2024 #48862

merged 4 commits into from
Dec 2, 2024

Conversation

steve-hardman
Copy link
Contributor

@steve-hardman steve-hardman commented Nov 26, 2024 •
edited
Loading

I have added banner for KubeCon India 2024 as requested in issue 48787

Banner link: https://deploy-preview-48862--kubernetes-io-main-staging.netlify.app/

This will resolve #48787

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 26, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit bccca47
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/674654e61df0c200083fa191
😎 Deploy Preview https://deploy-preview-48862--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/retitle Add banner for KubeCon India 2024

@k8s-ci-robot k8s-ci-robot changed the title Add new event Add banner for KubeCon India 2024 Nov 26, 2024
dipesh-rawat
dipesh-rawat reviewed Nov 26, 2024
View reviewed changes
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
data/announcements/scheduled.yaml Outdated Show resolved Hide resolved
@dipesh-rawat
Copy link
Member

/committee steering

This change will need steering committee approval.

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Nov 26, 2024
@dipesh-rawat
Copy link
Member

Visual reference for the KubeCon India banner in deploy preview page (here).

steve-hardman and others added 2 commits November 26, 2024 23:08
dipesh-rawat
dipesh-rawat reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sftim
Copy link
Contributor

sftim commented Nov 27, 2024

LGTM for SIG Docs

@steve-hardman
Copy link
Contributor Author

@kubernetes/steering-committee Can I please get a review and apporval for this banner PR?

saschagrunert
saschagrunert approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sftim
Copy link
Contributor

sftim commented Dec 2, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f595a50b690dfd63926c9a42da0388e0f47f2148

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2f1dd9 into kubernetes:main Dec 2, 2024
6 checks passed
@justaugustus
Copy link
Member

post-merge +1 (Steering)

@pohly
Copy link
Contributor

pohly commented Dec 2, 2024

LGTM (Steering)

1 similar comment
@BenTheElder
Copy link
Member

LGTM (Steering)

@pacoxu
Copy link
Member

pacoxu commented Dec 3, 2024

LGTM (Steering)

@steve-hardman steve-hardman deleted the add-banner branch December 3, 2024 22:51
@dipesh-rawat dipesh-rawat mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add banner for KubeCon 2024 India
9 participants
@steve-hardman @dipesh-rawat @sftim @k8s-ci-robot @justaugustus @pohly @BenTheElder @pacoxu @saschagrunert