Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving storage calls out (level up) from JobClient #711

Open
exu opened this issue Jan 6, 2022 · 0 comments
Open

Consider moving storage calls out (level up) from JobClient #711

exu opened this issue Jan 6, 2022 · 0 comments

Comments

@exu
Copy link
Member

exu commented Jan 6, 2022

pkg/jobs/jobclient.go

// TODO Consider moving launch of K8s job as always sync
// TODO Consider moving storage calls level up (remove dependency from here)
func (c *JobClient) LaunchK8sJobSync(image string, repo result.Repository, execution testkube.Execution) (result testkube.ExecutionResult, err error) {
	result = testkube.NewPendingExecutionResult()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant