Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Toggle theme button is missing. #59

Open
mkgupta01 opened this issue May 31, 2022 · 8 comments · May be fixed by #170
Open

[Bug] Toggle theme button is missing. #59

mkgupta01 opened this issue May 31, 2022 · 8 comments · May be fixed by #170
Labels
bug Something isn't working triage/accepted Accepted issue to work on

Comments

@mkgupta01
Copy link
Contributor

mkgupta01 commented May 31, 2022 •
edited
Loading

Description

  1. Button to switch from light mode to dark mode and vice versa is missing.
@mkgupta01 mkgupta01 added bug Something isn't working triage/awaiting Issue is under evaluation process labels May 31, 2022
@AvineshTripathi
Copy link
Collaborator

I would suggest looking at the documentation of Docusaurus and seeing if we can override the built-in functionality.

@anubha-v-ardhan anubha-v-ardhan added triage/accepted Accepted issue to work on and removed triage/awaiting Issue is under evaluation process labels Jun 4, 2022
@Shivansh-yadav13
Copy link

@mayankkuamr001 @AvineshTripathi I found that we can change the attr value in html tag data-theme to dark or light eg we can make a func and do setAttribute("data-theme", "dark")

@AvineshTripathi
Copy link
Collaborator

hey @Shivansh-yadav13 extremely sorry for not responding, do you want to create a toggle button?

@ghost
Copy link

ghost commented Aug 17, 2022

Hello, sir I am interested in solving this issue. so please assign to me this issue.

@ghost
Copy link

ghost commented Aug 17, 2022

Now, What should I do?

@Shivansh-yadav13
Copy link

hey @Shivansh-yadav13 extremely sorry for not responding, do you want to create a toggle button?

@AvineshTripathi sorry for late reply, @KetanParmar07 is interested so ig he can work on this issue.

@Shivansh-yadav13
Copy link

@KetanParmar07 are you working on this?

@Shivansh-yadav13 Shivansh-yadav13 linked a pull request Aug 23, 2022 that will close this issue
Open
@Shivansh-yadav13
Copy link

@AvineshTripathi can you review #170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage/accepted Accepted issue to work on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: add dark theme btn Shivansh-yadav13/kubesimplify-website
4 participants
@mkgupta01 @anubha-v-ardhan @AvineshTripathi @Shivansh-yadav13