Fix: Updated k8s version and GitHub action workflow version #212
Conversation
vishal210893
requested review from
FogDong,
wonderflow,
leejanee,
Somefive and
anoop2811
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 62.49% 67.41% +4.92%
==========================================
Files 62 62
Lines 4415 5939 +1524
==========================================
+ Hits 2759 4004 +1245
- Misses 1324 1584 +260
- Partials 332 351 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 3 issues across 9 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
There was a problem hiding this comment.
cubic found 10 issues across 11 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: vishal210893 <[email protected]>
… usage in tests Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: Ayush Kumar <[email protected]> Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
vishal210893
force-pushed
the
feature/upgrade-k8s-version
branch
from
01c04a6 to
283c988
Compare
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: vishal210893 <[email protected]>
Signed-off-by: Amit Singh <[email protected]>
…e handling in tests Signed-off-by: Amit Singh <[email protected]>
Signed-off-by: Amit Singh <[email protected]>
Signed-off-by: Amit Singh <[email protected]>
Signed-off-by: Amit Singh <[email protected]>
| @@ -92,7 +92,7 @@ var _ = BeforeSuite(func() { | |||
| Recorder: event.NewAPIRecorder(recorder), | |||
| } | |||
|
|
|||
| }, 60) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
| @@ -72,8 +72,7 @@ var _ = BeforeSuite(func(done Done) { | |||
| fakeDynamicClient := fake.NewSimpleDynamicClient(scheme) | |||
| singleton.DynamicClient.Set(fakeDynamicClient) | |||
|
|
|||
| close(done) | |||
| }, 60) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
| @@ -72,8 +72,7 @@ var _ = BeforeSuite(func(done Done) { | |||
| fakeDynamicClient := fake.NewSimpleDynamicClient(scheme) | |||
| singleton.DynamicClient.Set(fakeDynamicClient) | |||
|
|
|||
| close(done) | |||
| }, 60) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
| @@ -75,8 +75,7 @@ var _ = BeforeSuite(func(done Done) { | |||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme}) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Expect(k8sClient).ToNot(BeNil()) | |||
| close(done) | |||
| }, 120) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
| @@ -75,8 +75,7 @@ var _ = BeforeSuite(func(done Done) { | |||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme}) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Expect(k8sClient).ToNot(BeNil()) | |||
| close(done) | |||
| }, 120) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
| @@ -93,8 +93,7 @@ var _ = BeforeSuite(func(done Done) { | |||
| ns := corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: "vela-system"}} | |||
| Expect(k8sClient.Create(ctx, &ns)).Should(BeNil()) | |||
|
|
|||
| close(done) | |||
| }, 60) | |||
There was a problem hiding this comment.
Is this a timeout parameter that was supported earlier and not now?
Description of your changes
Updated the k8s version and the GitHub action workflow version
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Summary by cubic
Upgraded Kubernetes dependencies to v1.31.1 and updated GitHub Actions workflows to use the latest action versions.
Dependencies
Refactors