From edd8960f784d94ff70f7cd27e1c29d0a4d22c259 Mon Sep 17 00:00:00 2001 From: Or Shoval Date: Sun, 8 Sep 2024 18:18:49 +0300 Subject: [PATCH] e2e: Fix artifacts collecting Due to actions/upload-artifact#602 Hidden folders are skipped. We are using .output, so it was skipped and artifacts were not collected in case of an error. Rename it to fix the problem. Signed-off-by: Or Shoval --- .github/workflows/checks.yaml | 2 +- .gitignore | 1 + test/e2e/e2e_suite_test.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/checks.yaml b/.github/workflows/checks.yaml index 1ac015d4..5db31ae2 100644 --- a/.github/workflows/checks.yaml +++ b/.github/workflows/checks.yaml @@ -82,4 +82,4 @@ jobs: if: failure() with: name: test-logs - path: ./test/e2e/.output/*.log + path: ./test/e2e/_output/*.log diff --git a/.gitignore b/.gitignore index bd5105d4..9561a28d 100644 --- a/.gitignore +++ b/.gitignore @@ -29,3 +29,4 @@ go.work # output dir for the hack/cluster.sh artifacts and e2e tests .output +_output diff --git a/test/e2e/e2e_suite_test.go b/test/e2e/e2e_suite_test.go index 4b43db23..87286eed 100644 --- a/test/e2e/e2e_suite_test.go +++ b/test/e2e/e2e_suite_test.go @@ -34,7 +34,7 @@ import ( testenv "github.com/kubevirt/ipam-extensions/test/env" ) -const logsDir = ".output" // ./test/e2e/.output +const logsDir = "_output" // ./test/e2e/_output var _ = BeforeSuite(func() { ctrl.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true)))