Merge pull request #1285 from machadovilaca/CNV-55759

Alert VMStorageClassWarning only for Windows VMs

Author: kubevirt-bot

internal/operands/metrics/resources.go

@@ -166,10 +166,10 @@ func getAlertRules() ([]promv1.Rule, error) {
 		},
 		{
 			Alert: "VMStorageClassWarning",
-			Expr:  intstr.FromString("(count(kubevirt_ssp_vm_rbd_block_volume_without_rxbounce > 0) or vector(0)) > 0"),
+			Expr:  intstr.FromString("(count(kubevirt_ssp_vm_rbd_block_volume_without_rxbounce * on(name, namespace) (kubevirt_vmi_info{guest_os_name=\"Microsoft Windows\"} > 0 or kubevirt_vmi_info{os=~\"windows.*\"} > 0) > 0) or vector(0)) > 0"),
 			Annotations: map[string]string{
-				"summary":     "{{ $value }} Virtual Machines may cause reports of bad crc/signature errors due to certain I/O patterns",
-				"description": "When running VMs using ODF storage with 'rbd' mounter or 'rbd.csi.ceph.com provisioner', VMs may cause reports of bad crc/signature errors due to certain I/O patterns. Cluster performance can be severely degraded if the number of re-transmissions due to crc errors causes network saturation.",
+				"summary":     "{{ $value }} Windows Virtual Machines may cause reports of bad crc/signature errors due to certain I/O patterns.",
+				"description": "When running Windows VMs using ODF storage with 'rbd' mounter or 'rbd.csi.ceph.com provisioner', VMs may cause reports of bad crc/signature errors due to certain I/O patterns. Cluster performance can be severely degraded if the number of re-transmissions due to crc errors causes network saturation.",
 				"runbook_url": fmt.Sprintf(runbookURLTemplate, "VMStorageClassWarning"),
 			},
 			Labels: map[string]string{

tests/monitoring_test.go

@@ -277,7 +277,7 @@ var _ = Describe("Prometheus Alerts", func() {
 			alertShouldNotBeActive("VMStorageClassWarning")
 		})
 
-		It("[test_id:10549] Should fire VMStorageClassWarning when rxbounce is disabled", func() {
+		PIt("[test_id:10549] Should fire VMStorageClassWarning when rxbounce is disabled", func() {
 			vmName := createResources(true, false)
 			waitForSeriesToBeDetected(fmt.Sprintf("kubevirt_ssp_vm_rbd_block_volume_without_rxbounce{name='%s'} == 1", vmName))
 			waitForAlertToActivate("VMStorageClassWarning")