Skip to content

Commit fac29bf

Browse files
authored
fix: show sidecar fields when metrics is enabled. (#598)
Signed-off-by: José Guilherme Vanz <[email protected]>
1 parent 09cbbb8 commit fac29bf

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

charts/kubewarden-controller/questions.yaml

+13-13
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ questions:
124124
required: true
125125
label: Telemetry mode
126126
description: |
127-
Choose the telemetry mode. Sidecar mode will deploy an OpenTelemetry Collector
128-
as a sidecar container in the Kubewarden Controller pod. Custom mode will allow
129-
you to configure the OpenTelemetry Collector.
127+
Choose the telemetry mode.
128+
Sidecar mode will deploy an OpenTelemetry Collector as a sidecar container in the Kubewarden Controller pod.
129+
Custom mode will allow you to configure the OpenTelemetry Collector by your own and Kubewarden will send data to it.
130130
group: "Telemetry"
131131
- variable: "telemetry.metrics"
132132
type: boolean
@@ -137,6 +137,14 @@ questions:
137137
Enable metrics collection for all Policy Servers and the Kubewarden Controller.
138138
Important: Requires OpenTelemetry CRDs available.
139139
group: "Telemetry"
140+
- variable: "telemetry.sidecar.metrics.port"
141+
type: string
142+
default: "8080"
143+
label: Port
144+
description: |
145+
Port of the Prometheus exporter and PolicyServer metrics service.
146+
group: "Telemetry"
147+
show_if: "telemetry.mode=sidecar && telemetry.metrics=true"
140148
- variable: "telemetry.tracing"
141149
type: boolean
142150
default: false
@@ -146,30 +154,22 @@ questions:
146154
Enable tracing collection for all PolicyServers.
147155
Important: Requires OpenTelemetry CRDs available.
148156
group: "Telemetry"
149-
- variable: "telemetry.sidecar.metrics.port"
150-
type: string
151-
default: "8080"
152-
label: Port
153-
description: |
154-
Port of the Prometheus exporter and PolicyServer metrics service.
155-
group: "Telemetry"
156-
show_if: "telemetry.mode=sidecar"
157157
- variable: "telemetry.sidecar.tracing.jaeger.endpoint"
158158
type: string
159159
default: my-open-telemetry-collector.jaeger.svc.cluster.local:4317
160160
label: Jaeger endpoint configuration
161161
description: |
162162
Configuration of the OTLP/Jaeger exporter.
163163
group: "Telemetry"
164-
show_if: "telemetry.mode=sidecar"
164+
show_if: "telemetry.mode=sidecar && telemetry.tracing=true"
165165
- variable: "telemetry.sidecar.tracing.jaeger.tls.insecure"
166166
type: boolean
167167
default: false
168168
label: Jaeger endpoint insecure TLS configuration
169169
description: |
170170
Important: Insecure, not for production usage.
171171
group: "Telemetry"
172-
show_if: "telemetry.mode=sidecar"
172+
show_if: "telemetry.mode=sidecar && telemetry.tracing=true"
173173
- variable: "telemetry.custom.endpoint"
174174
type: string
175175
default: ""

0 commit comments

Comments
 (0)