From b01d6a557060a0bc3ee80c334c12a4f4931407c4 Mon Sep 17 00:00:00 2001
From: kinoppyd <ppyd@kinoppyd.dev>
Date: Wed, 21 Aug 2024 09:49:45 +0900
Subject: [PATCH] Use <button type="button"> instead of <a href="#">

---
 app/views/members/dialog.html.erb            | 4 ++--
 app/views/plans/_description_dialog.html.erb | 2 +-
 app/views/plans/_password_dialog.html.erb    | 2 +-
 app/views/plans/_rename_dialog.html.erb      | 2 +-
 app/views/plans/_setting_dialog.html.erb     | 2 +-
 app/views/profiles/_dialog.html.erb          | 2 +-
 app/views/profiles/show.html.erb             | 4 ++--
 app/views/schedules/_card.html.erb           | 2 +-
 app/views/teams/_rename_dialog.html.erb      | 2 +-
 9 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/app/views/members/dialog.html.erb b/app/views/members/dialog.html.erb
index 17db3469..d4063691 100644
--- a/app/views/members/dialog.html.erb
+++ b/app/views/members/dialog.html.erb
@@ -77,8 +77,8 @@
 
     <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
       <div class="flex justify-end">
-        <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+        <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
       </div>
     </div>
   <% end %>
-</dialog>
\ No newline at end of file
+</dialog>
diff --git a/app/views/plans/_description_dialog.html.erb b/app/views/plans/_description_dialog.html.erb
index e19c4f3a..634f375a 100644
--- a/app/views/plans/_description_dialog.html.erb
+++ b/app/views/plans/_description_dialog.html.erb
@@ -15,7 +15,7 @@
       </div>
       <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
         <div class="flex justify-end">
-          <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+          <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
           <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
         </div>
       </div>
diff --git a/app/views/plans/_password_dialog.html.erb b/app/views/plans/_password_dialog.html.erb
index ff10538b..a10cdcf9 100644
--- a/app/views/plans/_password_dialog.html.erb
+++ b/app/views/plans/_password_dialog.html.erb
@@ -16,7 +16,7 @@
     </div>
     <div class="flex flex-col border-t border-[rgb(214,211,208)] py-4 px-6">
       <div class="flex justify-end">
-        <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+        <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
         <%= f.submit I18n.t('button.make_editable'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
       </div>
     </div>
diff --git a/app/views/plans/_rename_dialog.html.erb b/app/views/plans/_rename_dialog.html.erb
index 9952888f..825c0766 100644
--- a/app/views/plans/_rename_dialog.html.erb
+++ b/app/views/plans/_rename_dialog.html.erb
@@ -15,7 +15,7 @@
       </div>
       <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
         <div class="flex justify-end">
-          <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+          <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
           <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
         </div>
       </div>
diff --git a/app/views/plans/_setting_dialog.html.erb b/app/views/plans/_setting_dialog.html.erb
index f904bd35..14452cc0 100644
--- a/app/views/plans/_setting_dialog.html.erb
+++ b/app/views/plans/_setting_dialog.html.erb
@@ -36,7 +36,7 @@
     </div>
     <div class="flex flex-col border-t border-[rgb(214,211,208)] py-4 px-6">
       <div class="flex justify-end">
-        <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+        <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
         <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
       </div>
     </div>
diff --git a/app/views/profiles/_dialog.html.erb b/app/views/profiles/_dialog.html.erb
index 9bd0e14f..e8e68d6a 100644
--- a/app/views/profiles/_dialog.html.erb
+++ b/app/views/profiles/_dialog.html.erb
@@ -14,7 +14,7 @@
       </div>
       <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
         <div class="flex justify-end">
-          <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+          <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
           <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
         </div>
       </div>
diff --git a/app/views/profiles/show.html.erb b/app/views/profiles/show.html.erb
index 28f02079..60c37aae 100644
--- a/app/views/profiles/show.html.erb
+++ b/app/views/profiles/show.html.erb
@@ -48,7 +48,7 @@
                       </div>
                       <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
                         <div class="flex justify-end">
-                          <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+                          <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
                         </div>
                       </div>
                     </dialog>
@@ -89,7 +89,7 @@
                         </div>
                         <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
                           <div class="flex justify-end">
-                            <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+                            <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
                           </div>
                         </div>
                       </dialog>
diff --git a/app/views/schedules/_card.html.erb b/app/views/schedules/_card.html.erb
index 1a5ebda7..29ac486c 100644
--- a/app/views/schedules/_card.html.erb
+++ b/app/views/schedules/_card.html.erb
@@ -76,7 +76,7 @@
                   </div>
                   <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
                     <div class="flex justify-end">
-                      <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+                      <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
                       <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#close", "word-counter-target": "submit" }, class: "primary-button" %>
                     </div>
                   </div>
diff --git a/app/views/teams/_rename_dialog.html.erb b/app/views/teams/_rename_dialog.html.erb
index fbc60935..f126b07f 100644
--- a/app/views/teams/_rename_dialog.html.erb
+++ b/app/views/teams/_rename_dialog.html.erb
@@ -24,7 +24,7 @@
         </div>
         <div class="border-t-[1px] border-[rgb(214,211,208)] flex flex-col py-4 px-6">
           <div class="flex justify-end">
-            <a href="#" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></a>
+            <button type="button" class="normal-button mr-2" data-action="click->dialog#close"><%= I18n.t('button.close')%></button>
             <%= f.submit I18n.t('button.save'), data: { action: "click->dialog#disable", "word-counter-target": "submit" }, class: "primary-button" %>
           </div>
         </div>