Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments should have attributes #66

Open
kujaku11 opened this issue Nov 4, 2021 · 0 comments
Open

Comments should have attributes #66

kujaku11 opened this issue Nov 4, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kujaku11
Copy link
Owner

kujaku11 commented Nov 4, 2021

Currently comments are free form strings, but to be more explicit a there should be Comments class. It should be a list of Comment objects. A Comment would have attributes:

  • comment --> a string comment
  • date --> date the comment was added
  • author --> Person object that has name and contact info
Comments()

{'comments':
  [
    {
       'comment' : "this is a comment",
       'date': "2020-01-01T12:00:00+00:00",
       'author: 
        {
           'name': "author name",
           'email': "[email protected]",
           'organization': "author organization",
        },
        {
       'comment' : "this is a second comment",
       'date': "2020-01-02T12:00:00+00:00",
       'author: 
        {
           'name': "author name",
           'email': "[email protected]",
           'organization': "author organization",
        },
    ]
}


      
@kujaku11 kujaku11 added the enhancement New feature or request label Nov 4, 2021
@kujaku11 kujaku11 self-assigned this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant