Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify pathRotateKey rotates properly #5

Open
kula opened this issue Feb 4, 2019 · 0 comments
Open

Verify pathRotateKey rotates properly #5

kula opened this issue Feb 4, 2019 · 0 comments

Comments

@kula
Copy link
Owner

kula commented Feb 4, 2019

client, err = b.getB2Client(ctx, req.Storage)
if err != nil {
return nil, errwrap.Wrapf("Failed to create new b2client: {{err}}", err)
}
b.client = client

  1. Is this safe while not holding the client lock?
  2. Do we actually force a new client here --- at this point, b.client isn't nil, so getB2Client should just return the current client....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant