Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blob data for presets #32

Open
kunalarya opened this issue Dec 16, 2021 · 0 comments
Open

Support blob data for presets #32

kunalarya opened this issue Dec 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kunalarya
Copy link
Owner

We can use any data format we want, e.g. RON, TOML, or JSON.

RON is a bit easier to map 1:1 to Rust objects, by definition, but isn't standard outside the Rust ecosystem. JSON can be difficult to edit/debug and without easy commenting support can complicate things like troubleshooting version differences. TOML is a nice middle ground.

A few open questions:

  • How do we want to store floats and float arrays. Storing as text is kinda nice for human consumption but loses information.
    • Plan of action therefore will be to store as hex (wrap floats in something that implements Serialize and Deserialize for hex strings).
@kunalarya kunalarya added the enhancement New feature or request label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant