Refactor validateNumber(...)

[kungfooman]

Currently it has some issues with false positives:

["str", "1", "NaN", NaN, new Date].map(isNaN);
// Outputs: [true, false, true, true, false]

It tests for: undefined / null / NaN / infinity... but it seems we also need a simple typeof check:

validateNumber(["1", 2, 3], 0); // Approved, but it should fail

RuntimeTypeInspector.js/src-runtime/validateNumber.mjs

Lines 8 to 28 in da93e3c

	function validateNumber(obj, prop) {
	const val = obj[prop];
	const type = typeof obj;
	if (val === null) {
	typecheckWarn(`${type}#${prop} null`, {obj});
	return false;
	}
	if (val === undefined) {
	typecheckWarn(`${type}#${prop} undefined`, {obj});
	return false;
	}
	if (isNaN(val)) {
	typecheckWarn(`${type}#${prop} NaN`, {obj});
	return false;
	}
	if (!isFinite(val)) {
	typecheckWarn(`${type}#${prop} +-Infinity`, {obj});
	return false;
	}
	return true;
	}

And then I also have to fix validateNumber @todo note in validateType.