Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keywords): extend the list of restricted names, with a test #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Apr 3, 2024

  1. fix(keywords): extend the list of restricted names, with a test

    I observed that the list of restricted words didn't cover some
    attractive words when I attempted to generate a Rust client for
    a schema that used keywords like `async` as field names.
    
    - Extended the list of names in `is_restricted()`.
    - Added a short yaml schema that uses all of the restricted words
      as field names. Put this fixture to work in a test, to ensure no
      regressions.
    
    The list is undoubtedly incomplete, but there is a very clear place
    to add new ones (thank you!) and now a test to validate it.
    ceejbot committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    aaa6007 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Adopt @pscott31's approach in pr kurtbuilds#15.

    This is the right way to do it.
    ceejbot committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a4c4826 View commit details
    Browse the repository at this point in the history