From 2a630a62f0f9e32844e81d5989fb3fa221dbce57 Mon Sep 17 00:00:00 2001 From: Leandro Poroli Date: Tue, 15 Oct 2024 12:17:03 -0300 Subject: [PATCH] adding a OPERATOR-TODO to fix service version --- kardinal/topology/topology.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kardinal/topology/topology.go b/kardinal/topology/topology.go index d0e4dc1..b9fcb20 100644 --- a/kardinal/topology/topology.go +++ b/kardinal/topology/topology.go @@ -365,7 +365,10 @@ func (clusterTopology *ClusterTopology) GetNetIngresses() ([]*net.Ingress, []*co for _, pathOriginal := range ruleOriginal.HTTP.Paths { target := clusterTopology.GetServiceByVersion(namespace, pathOriginal.Backend.Service.Name, activeFlowID) // fallback to baseline if backend not found at the active flow - // the baseline topology (or prod topology) flow ID and flow version are equal to the namespace these three should use same value + //OPERATOR-TODO + // the baseline topology (or prod topology) flow ID and flow version are equal to the namespace these three should use same value //TODO this doesn't apply for the current approach + //TODO with Kardinal-Kontrol the baselineFlowVersion and namespace where equal because Kontrol modify the Service's metadata like the 'version' label + //TODO we need to find a way to get the real version, not modified baselineFlowVersion := namespace if target == nil { target = clusterTopology.GetServiceByVersion(namespace, pathOriginal.Backend.Service.Name, baselineFlowVersion)