avoid trying to delete default namespace

kurtosis-tech · Oct 2, 2024 · 04d184c · 04d184c
1 parent 44451c8
commit 04d184c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/kardinal-manager/kardinal-manager/cluster_manager/cluster_manager.go b/kardinal-manager/kardinal-manager/cluster_manager/cluster_manager.go
@@ -34,6 +34,8 @@ const (
 	// TODO move these values to a shared library between Kardinal Manager, Kontrol and Kardinal CLI
 	kardinalLabelKey = "kardinal.dev"
 	enabledKardinal  = "enabled"
+
+	defaultNamespace = "default"
 )
 
 var (
@@ -428,6 +430,11 @@ func (manager *ClusterManager) removeKardinalNamespaces(ctx context.Context) err
 	}
 
 	for _, namespace := range kardinalNamespaces.Items {
+
+		if namespace.GetName() == defaultNamespace {
+			continue
+		}
+
 		if err := manager.removeNamespace(ctx, &namespace); err != nil {
 			return stacktrace.Propagate(err, "an error occurred while removing Kardinal namespace '%s'", namespace.GetName())
 		}

diff --git a/kardinal-manager/kardinal-manager/cluster_manager/cluster_manager_test.go b/kardinal-manager/kardinal-manager/cluster_manager/cluster_manager_test.go
@@ -7,10 +7,6 @@ import (
 	"testing"
 )
 
-const (
-	defaultNamespace = "default"
-)
-
 func TestClusterManager_GetVirtualServices(t *testing.T) {
 	ctx := context.Background()
 	clusterManager, err := getClusterManagerForTesting(t)