From ffa3519b307dfbda83b67c9912d85ce55d0bcc14 Mon Sep 17 00:00:00 2001 From: Laurent Luce Date: Mon, 5 Feb 2024 12:35:27 -0500 Subject: [PATCH 1/2] chore: Update node js version to 20 in the dev setup steps (#2110) ## Description: Update node js version to 20 in the dev setup steps. ## Is this change user facing? NO --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index ad13bf1161..7b6da21925 100644 --- a/README.md +++ b/README.md @@ -228,13 +228,13 @@ sudo apt update sudo apt install goreleaser ``` -#### Node (16.14 or above) and Yarn +#### Node (20.* or above) and Yarn On MacOS, using `NVM`: ```bash brew install nvm mkdir ~/.nvm -nvm install 16.14.0 +nvm install 20.11.0 npm install -g yarn ``` @@ -242,7 +242,7 @@ On Ubuntu, using `NVM`: ```bash curl https://raw.githubusercontent.com/creationix/nvm/master/install.sh | bash source ~/.bashrc -nvm install 16.14.0 +nvm install 20.11.0 npm install -g yarn ``` @@ -516,4 +516,4 @@ ktdev gateway [twitter]: https://twitter.com/KurtosisTech [starlark-explanation]: https://docs.kurtosis.com/explanations/starlark [stackoverflow-2022-developer-survey--other-tools]: https://survey.stackoverflow.co/2022/#most-popular-technologies-tools-tech-prof -[delve-docs]: https://github.com/go-delve/delve/blob/master/Documentation/cli/README.md \ No newline at end of file +[delve-docs]: https://github.com/go-delve/delve/blob/master/Documentation/cli/README.md From 1f738216851718bda1ebf9f9bf8936a715ae2cdf Mon Sep 17 00:00:00 2001 From: leoporoli Date: Mon, 5 Feb 2024 16:05:28 -0300 Subject: [PATCH 2/2] fix: adding the `core script build call`, which was removed by accident, in the main build script (#2118) ## Description: adding the `core script build call`, which was removed by accident, in the main build script ## Is this change user facing? NO ## References (if applicable): --- scripts/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/build.sh b/scripts/build.sh index f79dd383ca..d2c3cfc4eb 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -33,6 +33,7 @@ BUILD_SCRIPT_RELATIVE_FILEPATHS=( "metrics-library/scripts/build.sh" "enclave-manager/scripts/build.sh" "engine/scripts/build.sh" + "core/scripts/build.sh" ) # projects with debug mode enabled