Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move doc string validation to Kurtosis #2148

Closed
h4ck3rk3y opened this issue Feb 12, 2024 · 0 comments · Fixed by #2208 or #2210
Closed

move doc string validation to Kurtosis #2148

h4ck3rk3y opened this issue Feb 12, 2024 · 0 comments · Fixed by #2208 or #2210
Labels
feature request painful Painful bug

Comments

@h4ck3rk3y
Copy link
Contributor

Background & motivation

For now we validate doc strings inside the kurtosis-package-indexer / cloud-catalog but that is no good as the loop to fix a doc string is very long.

Desired behaviour

If there's a doc string kurtosis run should validate that too

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

What area of the product does this pertain to?

Other: anything not covered by the above
@github-actions github-actions bot added the painful Painful bug label Feb 12, 2024
@h4ck3rk3y h4ck3rk3y mentioned this issue Feb 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
@h4ck3rk3y
feat: allow users to validate their doc strings via linter (#2208)
a9e583d 
Closes #2148
@kurtosisbot kurtosisbot mentioned this issue Feb 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 29, 2024
@kurtosisbot
chore(main): release 0.87.3 (#2210)
fad6484 
🤖 I have created a release *beep* *boop*
---


##
[0.87.3](0.87.2...0.87.3)
(2024-02-28)


### Features

* add a url field to port that autopopulates if application protocol is
set ([#2211](#2211))
([35c913b](35c913b))
* added the get_service instruction
([#2233](#2233))
([7020183](7020183))
* allow users to validate their doc strings via linter
([#2208](#2208))
([a9e583d](a9e583d)),
closes [#2148](#2148)


### Bug Fixes

* fixing the Postgrest image label in the docs for the quickstart
([#2225](#2225))
([536a0b3](536a0b3))
* remove package json
([#2226](#2226))
([93bcf62](93bcf62))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this issue Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request painful Painful bug
Projects
None yet
Milestone
No milestone
1 participant
@h4ck3rk3y