Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions about your code #6

Open
vtddggg opened this issue Apr 18, 2018 · 2 comments
Open

Some questions about your code #6

vtddggg opened this issue Apr 18, 2018 · 2 comments

Comments

@vtddggg
Copy link

vtddggg commented Apr 18, 2018

Thank you for sharing!!

I found that you get color_image through bluring :
batch_colors = np.array([self.imageblur(ba,True) for ba in batch]) / 255.0

Bluring is a good way to get color prior when we have groundtruth images. But if I only have a line map (without groundtruth), bluring can not work because bluring a line image can not get any color informations. As your paper said, a color_predict network can predict the color from a line image. I think it is a very nice idea while I found main.py does not realize this part of functions. Maybe you have tried in guess_color.py.

Good job!!

@vtddggg
Copy link
Author

vtddggg commented Apr 18, 2018

I have understood what your code mean. It seems that a Variational Autoencoder is trained to guess the color information.

@zjgirl
Copy link

zjgirl commented Nov 24, 2018

Do you really think the code matchs with the paper? I think the code doesn't contain two networks (although the two networks are the same). It seems it achieves the direct network which has L1 loss and adversial loss. But it doesn't achieve what the paper says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants