-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coastsat into a package #55
Comments
Yes exactly, About the gdal issue: I will look into that and report back my findings. I have previously had problems with gdal and conda/pip. |
GDAL cannot be installed via pip on either Windows or Linux, as it needs a precompiled binary. I have nonetheless created a pull request, adding a little bit to the Readme, and a setup.py file.. Atleast it takes the burden away of messing with |
I too believe that coastsat should (additionally) be available via pip. Pre-requisite GDAL binaries can be installed separately from wheels (GDAL) created and maintained by Christoph Gohlke. |
thanks @borgstad for looking this up and making a PR #60, much appreciated. The only minor change is that I wouldn't call the package CoastSatDHI (or with the name of any organisation, includng mine) as we don't want to do any branding here but just open-source community development. Since there are still issues with the GDAL package, it's worth having a discussion on what are the possible options to make the installation of coastsat as simple as possible. About half of the issues opened by users are on the installation! From @cosstas suggestion above we could also run a command to download the GDAL wheels separately and then install with pip. One thing to keep in mind is that structure of coastsat is still evolving and we want to keep it flexible so that users can just pull the changes from github without having to re-install the package each time. Keen to have current users opinion on this |
This is definitely an error on my part, I pushed a wrong version, sorry about the confusion, I will updated it as soon as I have time.
Nice suggestion! |
I am in favor of recommending to the user of the most favorable way to install GDAL manually on each platform. In my experience, this is the common practice for pypi packages that require GDAL. At least to begin with.
If coastsat is following a release schedule in pypi, (at least for major updates) a simple |
@kvos coastSat is applicable for island?;downloading images is possible but further steps end with an error |
Today I found some time to install CoastSat and have a go at it. I copied the sources in my site-packages folder. Earth engine and google api were installed using pypi. The rest were already already installed manually as described before. And that was all, I was able to run the example. |
there have been so many issues open because of the installation process that any update that could make the installation easier is more than welcome. What is required to make a pypi package? |
Haven't published a package myself, but since @borgstad committed #60, I think the maintainer (you:-)) must create an account with PyPI, create a package and upload it. The instructions in this link (https://packaging.python.org/tutorials/packaging-projects/) are straightforward and don't look that demanding. I suppose maintaining both a conda repository and a PyPI package adds some effort to publishing a version. |
I am working towards creating a PyPi package. First of all setup.py needs be defined so that pip install can work. @kvos (or anyone else interested) Can you try installing CoastSat from my branch using the following command: |
sounds great! will test it out. What happens with the GDAL library though for new users? |
I haven't come across an automated solution yet. I guess the user should be directed to take the following steps:
As mentioned before, rasterio is taking a similar approach: (https://github.com/mapbox/rasterio#dependencies). This is meant to be an alternative anyway. The user can always be recommended to take the easiest path through anaconda. |
It would be nice to re-write the gdal calls with rasterio instead of gdal calls. It would make it more modern, easier to maintain, and there are rasterio wheels available. |
Hey all, have there been any updates in the creation of a coastsat package? I'm interested in helping out in any way I can. I see the installation of GDAL seems to be the biggest obstacle. |
In order to use coastsat, you have to set your pythonpath/start your environment with coastsat as root dir.
It would be really nice if CoastSat existed as an installable package.
If you are interested, I could create a PR
The text was updated successfully, but these errors were encountered: