Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app rather large #24

Open
jidanni opened this issue Jul 5, 2019 · 4 comments
Open

app rather large #24

jidanni opened this issue Jul 5, 2019 · 4 comments
Labels
enhancement New feature or request high value high value features or enhancements

Comments

@jidanni
Copy link

jidanni commented Jul 5, 2019

Why is this app 250 megabytes big?

Shouldn't it be just 2.5 megabytes big?

@jidanni
Copy link
Author

jidanni commented Jul 5, 2019

oh, I see. It's not the APK size I was looking at. It was the total memory size on my device. But anyway yeah, why does it need to store 250 megabytes?

@kwatkins
Copy link
Contributor

kwatkins commented Jul 5, 2019 via email

@jidanni
Copy link
Author

jidanni commented Jul 6, 2019 via email

@kwatkins
Copy link
Contributor

kwatkins commented Jul 23, 2019

You are totally right on this. Currently binaries are bundled into one APK and the app has gotten so large it's likely throwing up a "need wifi to download" type of adoption barrier.

Tasks for this issue, and it'll likely come in phases,

  • Trim binaries to the "core", for commands beyond that, bundle inside another zip/package that will get installed on-demand or if a command is run that requires it. Add another field for commands containing the url/location of the binary with integrity hashes. If there is already a tool out there that does this, even better.
  • Update build/release to create apks for different architectures and include only the binaries and libs for that architecture. When getting the extra tools, we need to make sure an architecture check is done and pulls down the binaries for that platform.

@kwatkins kwatkins added enhancement New feature or request high value high value features or enhancements labels Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high value high value features or enhancements
Projects
None yet
Development

No branches or pull requests

2 participants