Add 2 parameters to [user_favorites] shortcode to filter by taxonomy terms also #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 arguments to the shortcode: - taxonomy - terms they use Favorites filters
|
Unfortunately, the [favorites_button] is not aware of the taxonomy filter, so when you click the button to add or remove a favorite, it updates the list showing all favourite posts, regardless the filters defines in [user_favorites] shortcode used to generate the list at load page time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 arguments to the shortcode:
Simply uses already coded Favorites filters, to filter user favorites by taxonomy terms, as well as by post type