Skip to content

Fix sync issues with large post counts and max input vars #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sync issues with large post counts and max input vars #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 54 additions & 49 deletions app/Entities/Post/PostUpdateRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php
<?php
namespace NestedPages\Entities\Post;

use NestedPages\Form\Validation\Validation;
Expand All @@ -9,7 +9,7 @@
/**
* Post Create/Update Methods
*/
class PostUpdateRepository
class PostUpdateRepository
{
/**
* Validation Class
Expand Down Expand Up @@ -52,7 +52,7 @@ public function __construct()
* @param int parent
* @since 1.0
*/
public function updateOrder($posts, $parent = 0, $filtered = false)
public function updateOrder($posts, $filtered)
{
$this->validation->validatePostIDs($posts);
$post_type = get_post_type($posts[0]['id']);
Expand All @@ -64,8 +64,12 @@ public function updateOrder($posts, $parent = 0, $filtered = false)
$post_id = sanitize_text_field($post['id']);
$original_modifed_date = get_post_modified_time('Y-m-d H:i:s', false, $post_id);
$original_modifed_date_gmt = get_post_modified_time('Y-m-d H:i:s', true, $post_id);

if ( !$filtered ) $args['post_parent'] = intval($parent);

// if ( !$filtered ) $args['post_parent'] = intval($parent); // Not used?

// Extract data
$parent = $post['parent_id'];
$order = $post['order'];

// Update post hook causes server timeout on large sites, but may be required by some users
if ( $update_post_hook ) wp_update_post(['ID' => $post_id]);
Expand All @@ -74,31 +78,29 @@ public function updateOrder($posts, $parent = 0, $filtered = false)
$query = $wpdb->prepare(
"UPDATE $wpdb->posts
SET menu_order = '%d', post_parent = '%d', post_modified = '%s', post_modified_gmt = '%s'
WHERE ID = '%d'",
intval($key),
intval($parent),
$original_modifed_date,
$original_modifed_date_gmt,
WHERE ID = '%d'",
intval($order), // Use order from front-end
intval($parent), // Use parent from front-end
$original_modifed_date,
$original_modifed_date_gmt,
intval($post_id)
);
else : // The posts are filtered, don't update the parent
$query = $wpdb->prepare(
"UPDATE $wpdb->posts
SET menu_order = '%d', post_modified = '%s', post_modified_gmt = '%s'
WHERE ID = '%d'",
intval($key),
$original_modifed_date,
$original_modifed_date_gmt,
WHERE ID = '%d'",
intval($order), // Use order from front-end
$original_modifed_date,
$original_modifed_date_gmt,
intval($post_id)
);
);
endif;

$wpdb->query( $query );
do_action('nestedpages_post_order_updated', $post_id, $parent, $key, $filtered);
do_action('nestedpages_post_order_updated', $post_id, $parent, $order, $filtered);

wp_cache_delete( $post_id, 'posts' );

if ( isset($post['children']) ) $this->updateOrder($post['children'], $post_id);
}
do_action('nestedpages_posts_order_updated', $posts, $parent);
return true;
Expand All @@ -119,19 +121,19 @@ public function updatePost($data, $append_taxonomies = false)

$this->validation->validateCustomFields($data);

if ( isset($data['post_title']) && $data['post_title'] == "" ){
if ( isset($data['post_title']) && $data['post_title'] == "" ){
$this->validation->checkEmpty($data['post_title'], __('Title', 'wp-nested-pages'));
} elseif ( isset($data['post_title']) ){
$updated_post['post_title'] = esc_attr($data['post_title']);
}

if ( isset($data['post_name']) )
if ( isset($data['post_name']) )
$updated_post['post_name'] = sanitize_text_field($data['post_name']);

if ( isset($data['post_author']) )
if ( isset($data['post_author']) )
$updated_post['post_author'] = sanitize_text_field($data['post_author']);

if ( isset($data['post_password']) )
if ( isset($data['post_password']) )
$updated_post['post_password'] = sanitize_text_field($data['post_password']);

if ( !$this->post_type_repo->standardFieldDisabled('allow_comments', sanitize_text_field($data['post_type'])) ){
Expand Down Expand Up @@ -189,9 +191,9 @@ public function updateTemplate($data)
{
if ( isset($data['page_template']) && current_user_can('edit_post', $data['post_id']) ){
$template = sanitize_text_field($data['page_template']);
update_post_meta(
$data['post_id'],
'_wp_page_template',
update_post_meta(
$data['post_id'],
'_wp_page_template',
$template
);
}
Expand All @@ -207,9 +209,9 @@ public function updateNavStatus($data)
if ( !current_user_can('edit_post', $data['post_id']) ) return;
$status = ( isset($data['nav_status']) && $data['nav_status'] == 'hide' ) ? 'hide' : 'show';
$id = ( isset($data['post_id']) ) ? $data['post_id'] : $this->new_id;
update_post_meta(
$id,
'_np_nav_status',
update_post_meta(
$id,
'_np_nav_status',
$status
);
}
Expand All @@ -223,7 +225,7 @@ private function updateNestedPagesStatus($data)
{
if ( !current_user_can('edit_post', $data['post_id']) ) return;
if ( $this->post_type_repo->standardFieldDisabled('hide_in_np', sanitize_text_field($data['post_type'])) ) return;

$status = ( isset($data['nested_pages_status']) && $data['nested_pages_status'] == 'hide' ) ? 'hide' : 'show';
$id = ( isset($data['post_id']) ) ? $data['post_id'] : $this->new_id;
update_post_meta(
Expand All @@ -243,9 +245,9 @@ private function updateNavTitle($data)
if ( !current_user_can('edit_post', $data['post_id']) ) return;
if ( isset($data['np_nav_title']) ){
$title = sanitize_text_field($data['np_nav_title']);
update_post_meta(
$data['post_id'],
'_np_nav_title',
update_post_meta(
$data['post_id'],
'_np_nav_title',
$title
);
}
Expand All @@ -261,9 +263,9 @@ private function updateNavCSS($data)
if ( !current_user_can('edit_post', $data['post_id']) ) return;
if ( isset($data['np_nav_css_classes']) ){
$css_classes = sanitize_text_field($data['np_nav_css_classes']);
update_post_meta(
$data['post_id'],
'_np_nav_css_classes',
update_post_meta(
$data['post_id'],
'_np_nav_css_classes',
$css_classes
);
}
Expand All @@ -280,9 +282,9 @@ private function updateNavCustomUrl($data)
if ( isset($data['np_nav_custom_url']) ){
$url_input = $data['np_nav_custom_url'];
$url = ( $url_input == '#' ) ? '#' : esc_url($data['np_nav_custom_url']);
update_post_meta(
$data['post_id'],
'_np_nav_custom_url',
update_post_meta(
$data['post_id'],
'_np_nav_custom_url',
$url
);
}
Expand All @@ -298,9 +300,9 @@ private function updateTitleAttribute($data)
if ( !current_user_can('edit_post', $data['post_id']) ) return;
if ( isset($data['np_title_attribute']) ){
$title_attr = sanitize_text_field($data['np_title_attribute']);
update_post_meta(
$data['post_id'],
'_np_title_attribute',
update_post_meta(
$data['post_id'],
'_np_title_attribute',
$title_attr
);
}
Expand All @@ -321,9 +323,9 @@ private function updateCustomFields($data)
$field_key = preg_replace('/nptype_(.*)_nptype_/', '', $field_key);
if ( $field_type == 'url' ) $value = esc_url($value);
if ( !current_user_can('edit_post', $data['post_id']) ) continue;
update_post_meta(
$data['post_id'],
$field_key,
update_post_meta(
$data['post_id'],
$field_key,
$value
);
}
Expand Down Expand Up @@ -412,9 +414,9 @@ private function updateLinkTarget($data)
if ( !current_user_can('edit_post', $data['post_id']) ) return;
$link_target = ( isset($data['link_target']) && $data['link_target'] == "_blank" ) ? "_blank" : "";
$id = ( isset($data['post_id']) ) ? $data['post_id'] : $this->new_id;
update_post_meta(
$id,
'_np_link_target',
update_post_meta(
$id,
'_np_link_target',
$link_target
);
}
Expand Down Expand Up @@ -476,15 +478,18 @@ private function updateMenuMeta($data)
public function updateRedirect($data)
{
if ( !current_user_can( 'edit_post', $data['post_id'] ) ) return false;
$menu_order = isset($data['menu_order']) ? $data['menu_order'] : 0;
$updated_post = [
'ID' => sanitize_text_field($data['post_id']),
'post_title' => sanitize_text_field($data['post_title']),
'post_status' => sanitize_text_field($data['_status']),
'post_parent' => sanitize_text_field($data['parent_id']),
'menu_order' => $menu_order
];

// Only set if passed from front-end, default to existing order
if (isset($data['menu_order'])) {
$updated_post['menu_order'] = $data['menu_order'];
}

if ( isset($data['post_content']) && $data['post_content'] !== "" ){
$updated_post['post_content'] = esc_url($data['post_content']);
}
Expand Down
6 changes: 3 additions & 3 deletions app/Form/Listeners/Sort.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?php
<?php
namespace NestedPages\Form\Listeners;

use NestedPages\Entities\PluginIntegration\IntegrationFactory;
Expand All @@ -8,7 +8,7 @@
* updates menu order & page parents
* @return json response
*/
class Sort extends BaseHandler
class Sort extends BaseHandler
{
public function __construct()
{
Expand All @@ -25,7 +25,7 @@ private function updateOrder()
{
$posts = $this->data['list'];
$filtered = ( isset($this->data['filtered']) && $this->data['filtered'] == 'true' ) ? true : false;
$order = $this->post_update_repo->updateOrder($posts, 0, $filtered);
$order = $this->post_update_repo->updateOrder($posts, $filtered);
if ( $order ){
if ( $this->integrations->plugins->wpml->installed ) $this->integrations->plugins->wpml->syncPostOrder($posts);
$this->response = ['status' => 'success', 'message' => __('Page order successfully updated.','wp-nested-pages') ];
Expand Down
Loading