Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio CR modifications done by the Integration test suites are not reverted after tests are completed #1369

Open
mluk-sap opened this issue Oct 10, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mluk-sap
Copy link
Contributor

mluk-sap commented Oct 10, 2024

Description

Integration tests (v2alpha1 and ory) patch the Istio CR in order to include the external authorizer. This is not reverted after the tests are completed. It is not a good practice, which may cause end-developer confusion.

Expected result

Istio CR should be reverted to the original state (authorizer added by the test suite hook should be removed).

Actual result

Istio CR remains modified after tests are finished.

Steps to reproduce

kubectl apply -f https://github.com/kyma-project/istio/releases/download/1.9.0/istio-default-cr.yaml && make test-integration-v2alpha1 && kubectl get istio -n kyma-system -o yaml

It shows that the authorizer is there:

...
  spec:
    config:
      authorizers:
      - headers:
          inCheck:
            include:
            - x-ext-authz
        name: sample-ext-authz-http
        port: 8000
        service: ext-authz.ext-auth.svc.cluster.local
...
@mluk-sap mluk-sap added the kind/bug Categorizes issue or PR as related to a bug. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant