Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Application Connector module [EPIC] #154

Closed
35 tasks done
franpog859 opened this issue Oct 17, 2022 · 5 comments
Closed
35 tasks done

Create Application Connector module [EPIC] #154

franpog859 opened this issue Oct 17, 2022 · 5 comments
Assignees
Labels
area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@franpog859
Copy link

franpog859 commented Oct 17, 2022

Description

Application Connector needs to be moved to the modular architecture according to this concept.

Reasons

Application Connector should be more independent so that it must be possible to install, upgrade and operate it separately without dependencies on other Kyma modules.

Acceptance criteria

Release 1.0.0:

  • Application Connector module must have self-healing properties.
  • Operator's configuration must be defined dedicated CRD
  • Module must contain legacy Application Connector Components : Application Gateway and Connectivity Validator.

Release 1.1.0:

  • Module must contain all Application Connector Components : Application Gateway, Connectivity Validator, and Compass Runtime Agent.

Prerequisites:

Workplan:

Until the end of September, Release MVP:

Release required tasks, until 25 October: Milestone 1.0.0

Release hardening, until mid of November: Milestone 1.1.0

Consider to close as non-relevant:

Additional information

@franpog859 franpog859 added area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/feature Categorizes issue or PR as related to a new feature. labels Oct 17, 2022
@franpog859 franpog859 changed the title Implement Application Connector Operator Move Application Connector to the Operator framework Oct 17, 2022
@franpog859 franpog859 added this to the Future milestone Oct 17, 2022
@akgalwas
Copy link
Contributor

akgalwas commented Nov 24, 2022

For the time being Application Connector integration tests do not need to be modified. At some point we will move from Kyma repository. We will need to establish new pipelines and adjust the tests code if needed, however, it is not the top priority for now.
Additional question: should we test Operator along with Compass Connector components (Application Gateway, Connectivity Validator, and Compass Runtime Agent)? Or Operator and stuff it install should be tested separately?

@akgalwas
Copy link
Contributor

We have three areas to test:

  • Operator behaviour
  • Application Gateway, Application Validator, and Compass Runtime Agent
  • Compass Manager logic

We discussed the topic and agreed to use contract testing approach:

  • Application Connector Module Operator will be tested separately with some mocked chart.
  • Application Connector components will be tested separately and most functionality will be reused from existing tests (new pipeline will be needed)

@akgalwas
Copy link
Contributor

Application Operator Module CRD must contain the following properties:

  • domainName to be used in Istio Gateway, and Istio Virtual Service
  • secret with TLS certificate to be used by Istio Gateway

Both values are optional so Operator must implement fallbacks:

  • if secret is not provided, Certificate CR must be created
  • if domainName is not provided, Gardener's domain must be used

@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2023
@franpog859 franpog859 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2023
@m00g3n m00g3n changed the title Move Application Connector to the Operator framework Create Application Connector module Jul 12, 2023
@tobiscr tobiscr changed the title Create Application Connector module Create Application Connector module [EPIC] Dec 29, 2023
@tobiscr tobiscr transferred this issue from kyma-project/kyma Jan 29, 2024
@tobiscr
Copy link
Contributor

tobiscr commented May 7, 2024

Done

@tobiscr tobiscr closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity area/documentation Issues or PRs related to documentation kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants